| Summary: | Reindent circ-menu.inc | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | RESOLVED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | david, fridolin.somers, lucas |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This updates the circ-menu.inc include file used for the left-hand sidebar menu on circulation pages (when the CircSidebar system preference). It reindents the file so that it has consistent indentation, and adds comments to highlight the markup structure. These changes have no visible effect on the pages.
|
Version(s) released in: |
24.11.00,24.05.02
|
| Circulation function: | |||
| Attachments: |
Bug 36911: Reindent circ-menu.inc
Bug 36911: (follow-up) Add markup comments Bug 36911: Reindent circ-menu.inc Bug 36911: (follow-up) Add markup comments |
||
|
Description
Owen Leonard
2024-05-21 16:36:04 UTC
Created attachment 166985 [details] [review] Bug 36911: Reindent circ-menu.inc This patch reindents the circ-menu include file so that it has consistent indentation. These changes should have no visible effect on the page. To test, apply the patch and enable the 'CircSidebar' system preference if necessary. - View any circulation page, including the checkout page, to confirm that the left-hand sidebar menu is unchanged. - Test with the 'patronimages' system preference both on and off. Viewing the diff while ignoring whitespace changes should show only places where a line break was added. Created attachment 166986 [details] [review] Bug 36911: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Created attachment 167199 [details] [review] Bug 36911: Reindent circ-menu.inc This patch reindents the circ-menu include file so that it has consistent indentation. These changes should have no visible effect on the page. To test, apply the patch and enable the 'CircSidebar' system preference if necessary. - View any circulation page, including the checkout page, to confirm that the left-hand sidebar menu is unchanged. - Test with the 'patronimages' system preference both on and off. Viewing the diff while ignoring whitespace changes should show only places where a line break was added. Signed-off-by: David Nind <david@davidnind.com> Created attachment 167200 [details] [review] Bug 36911: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: David Nind <david@davidnind.com> Picking an easy one out of QA queue :) Pushed for 24.11! Well done everyone, thank you! Backported to 24.05.x for upcoming 24.05.02 I prefer not to impact oldstable 23.11.x No changes to the manual are required - there are no changes to the UI or functionality. |