Bug 36914

Summary: DBIx::Class warning from shelves.pl
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Architecture, internals, and plumbingAssignee: Jonathan Druart <jonathan.druart>
Status: RESOLVED FIXED QA Contact: Marcel de Rooy <m.de.rooy>
Severity: normal    
Priority: P5 - low CC: david, fridolin.somers, lucas, wainuiwitikapark
Version: unspecified   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36858
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.06,23.05.12
Circulation function:
Bug Depends on: 28561    
Bug Blocks:    
Attachments: Bug 36914: Remove DBIC warning in shelves.pl
Bug 36914: Remove DBIC warning in shelves.pl

Description Jonathan Druart 2024-05-22 07:34:40 UTC
DBIx::Class::ResultSet::_construct_results(): Unable to properly collapse has_many results in iterator mode due to order criteria - performed an eager cursor slurp underneath. Consider
 using ->all() instead at /kohadevbox/koha/Koha/Objects.pm line 319
Comment 1 Jonathan Druart 2024-05-22 07:35:15 UTC
Exactly the same as bug 28561, but for virtualshelves/shelves.pl (vs opac/opac-shelves.pl)
Comment 2 Jonathan Druart 2024-05-22 07:36:39 UTC
Created attachment 167005 [details] [review]
Bug 36914: Remove DBIC warning in shelves.pl

Same fix as Bug 28561: Remove DBIC warning in opac-shelves
But for staff
Comment 3 Marcel de Rooy 2024-05-22 11:16:58 UTC
Created attachment 167021 [details] [review]
Bug 36914: Remove DBIC warning in shelves.pl

Same fix as Bug 28561: Remove DBIC warning in opac-shelves
But for staff

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Katrin Fischer 2024-05-22 14:20:22 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 5 Fridolin Somers 2024-05-29 14:11:14 UTC
Pushed to 23.11.x for 23.11.06
Comment 6 Lucas Gass (lukeg) 2024-05-31 13:20:58 UTC
Backported to 23.05.x for upcoming 23.05.12
Comment 7 Wainui Witika-Park 2025-06-24 01:53:13 UTC
Not backporting to 22.11 unless requested
Comment 8 David Nind 2025-07-01 10:38:43 UTC
No updates to the manual required.