Summary: | label-item-search.pl paging doesn't work (due to CSRF changes) | ||
---|---|---|---|
Product: | Koha | Reporter: | David Cook <dcook> |
Component: | Label/patron card printing | Assignee: | David Cook <dcook> |
Status: | RESOLVED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | normal | ||
Priority: | P5 - low | CC: | david, fridolin.somers, m.de.rooy |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
24.05.00
|
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 36192, 30745 | ||
Attachments: |
Bug 36931: Fix label-item-search.pl by removing CSRF requirement
Bug 36931: Fix label-item-search.pl by removing CSRF requirement Bug 36931: Fix label-item-search.pl by removing CSRF requirement |
Description
David Cook
2024-05-23 06:22:24 UTC
Created attachment 167063 [details] [review] Bug 36931: Fix label-item-search.pl by removing CSRF requirement This change converts a stateless POST into a GET, so that the paging of the label-item-search.pl results works again. Test plan: 0. Apply the patch and restart Koha 1. Go to http://localhost:8081/cgi-bin/koha/labels/label-edit-batch.pl?op=new 2. Click "Add item(s)" 3. Add '05/01/2000' in "Added on or after date:" and click "Search" 4. Page through the results 5. Rejoice Created attachment 167077 [details] [review] Bug 36931: Fix label-item-search.pl by removing CSRF requirement This change converts a stateless POST into a GET, so that the paging of the label-item-search.pl results works again. Test plan: 0. Apply the patch and restart Koha 1. Go to http://localhost:8081/cgi-bin/koha/labels/label-edit-batch.pl?op=new 2. Click "Add item(s)" 3. Add '05/01/2000' in "Added on or after date:" and click "Search" 4. Page through the results 5. Rejoice Signed-off-by: David Nind <david@davidnind.com> Created attachment 167158 [details] [review] Bug 36931: Fix label-item-search.pl by removing CSRF requirement This change converts a stateless POST into a GET, so that the paging of the label-item-search.pl results works again. Test plan: 0. Apply the patch and restart Koha 1. Go to http://localhost:8081/cgi-bin/koha/labels/label-edit-batch.pl?op=new 2. Click "Add item(s)" 3. Add '05/01/2000' in "Added on or after date:" and click "Search" 4. Page through the results 5. Rejoice Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed for 24.05! Well done everyone, thank you! Not for 23.11.x No changes required to the manual. |