Bug 36936

Summary: api/v1/bookings.t generates warnings
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Test SuiteAssignee: Martin Renvoize (ashimema) <martin.renvoize>
Status: Pushed to oldstable --- QA Contact: Marcel de Rooy <m.de.rooy>
Severity: trivial    
Priority: P5 - low CC: fridolin.somers, lucas, m.de.rooy, tomascohen
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00,24.05.06,23.11.11
Circulation function:
Bug Depends on: 35248    
Bug Blocks: 25515    
Attachments: Bug 36936: Squash warning in bookings test
Bug 36936: Squash warning in bookings test
Bug 36936: (QA follow-up) Make the test work on MySQL 8.x

Description Jonathan Druart 2024-05-23 07:39:59 UTC
t/db_dependent/api/v1/bookings.t .. 2/5 DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Duplicate entry '6' for key 'PRIMARY' at /kohadevbox/koha/Koha/Object.pm line 172
Comment 1 Martin Renvoize (ashimema) 2024-06-26 13:14:08 UTC
Created attachment 168142 [details] [review]
Bug 36936: Squash warning in bookings test

Simple catch for the warning throwing by DuplicateID exceptions in the
bookings.t api tests.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 2 Martin Renvoize (ashimema) 2024-06-26 13:14:55 UTC
Trivial patch to catch and test for the thrown warning instead of letting it pass through in the tests.

Straight SO
Comment 3 Marcel de Rooy 2024-06-28 06:21:44 UTC
Created attachment 168219 [details] [review]
Bug 36936: Squash warning in bookings test

Simple catch for the warning throwing by DuplicateID exceptions in the
bookings.t api tests.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Katrin Fischer 2024-06-28 11:50:18 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 5 Tomás Cohen Arazi (tcohen) 2024-07-25 17:47:16 UTC
Created attachment 169611 [details] [review]
Bug 36936: (QA follow-up) Make the test work on MySQL 8.x

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 6 Tomás Cohen Arazi (tcohen) 2024-07-25 17:47:48 UTC
Pushed follow-up to main to fix issues with MySQL 8.x:

https://jenkins.koha-community.org/job/Koha_Main_My8/1322/consoleFull
Comment 7 Lucas Gass (lukeg) 2024-11-18 16:54:15 UTC
Backported to 24.05.x for upcoming 24.05.06
Comment 8 Fridolin Somers 2024-12-02 10:12:20 UTC
Pushed to 23.11.x for 23.11.11