| Summary: | ERM eUsage reports: only the first 20 data providers are listed when creating a new report | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Michaela Sieber <michaela.sieber> |
| Component: | ERM | Assignee: | Matt Blenkinsop <matt.blenkinsop> |
| Status: | RESOLVED FIXED | QA Contact: | Pedro Amorim <pedro.amorim> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | david, fridolin.somers, jonathan.druart, jonathan.field, lucas, matt.blenkinsop, pedro.amorim, wainuiwitikapark |
| Version: | unspecified | Keywords: | rel_23_11_candidate |
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36392 | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This fixes the "Choose data provider" dropdown list when creating a usage report in ERM so that all providers are listed (ERM > eUsage > Reports > Create report). Before this, it was only listing the first 20 data providers.
|
Version(s) released in: |
24.11.00,24.05.02,23.11.07
|
| Circulation function: | |||
| Attachments: |
Bug 36956: Allow all providers to be displayed in reports
Bug 36956: Allow all providers to be displayed in reports Bug 36956: Allow all providers to be displayed in reports |
||
|
Description
Michaela Sieber
2024-05-24 12:08:00 UTC
Created attachment 167217 [details] [review] Bug 36956: Allow all providers to be displayed in reports This patch fixes an incorrect usage of the API which was only returning 20 results. Test plan: 1) Go to ERM module and make sure you have more than 21 data providers stored in your database. 2) Go to eUsage / reports and create new report (cgi-bin/koha/erm/eusage/reports) 3) Check that only the first 20 data providers are displayed in the drop down 4) Apply patch 5) yarn build or reset_all to rebuild the javascript 6) Repeat steps 1-3, all providers should now be displayed Created attachment 167221 [details] [review] Bug 36956: Allow all providers to be displayed in reports This patch fixes an incorrect usage of the API which was only returning 20 results. Test plan: 1) Go to ERM module and make sure you have more than 21 data providers stored in your database. 2) Go to eUsage / reports and create new report (cgi-bin/koha/erm/eusage/reports) 3) Check that only the first 20 data providers are displayed in the drop down 4) Apply patch 5) yarn build or reset_all to rebuild the javascript 6) Repeat steps 1-3, all providers should now be displayed Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Created attachment 167933 [details] [review] Bug 36956: Allow all providers to be displayed in reports This patch fixes an incorrect usage of the API which was only returning 20 results. Test plan: 1) Go to ERM module and make sure you have more than 20 data providers stored in your database. 1) (Optional) Run the following command (k-t-d) to create 21 data providers: perl -MKoha::Database -e ' my $schema = Koha::Database->schema; $schema->resultset("ErmUsageDataProvider")->create({ name => "name ".$_ }) for (1..21) ' 2) Go to eUsage / reports and create new report (cgi-bin/koha/erm/eusage/reports) 3) Check that only the first 20 data providers are displayed in the drop down 4) Apply patch 5) yarn build or reset_all to rebuild the javascript 6) Repeat steps 1-3, all providers should now be displayed PA amended patch: Updated commit message test plan Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Such a small change, such a big effect :) Pushed for 24.11! Well done everyone, thank you! Adding backport release keywords, can we please add this to 24.05.x and 23.11.x. Backported to 24.05.x for upcoming 24.05.02 Pushed to 23.11.x for 23.11.07 not backporting to 23.05.x unless requested I have: 1. Added a release note. 2. Removed the rel_23_11_candidate keyword, as it was pushed for 23.11.07. 3. Updated the status to RESOLVED FIXED - not backported to 23.05, no changes to the ERM chapter of the manual are required. |