Bug 36964

Summary: PatronSelfRegistrationDefaultCategory shouldn't be necessary if categorycode isn't hidden
Product: Koha Reporter: David Cook <dcook>
Component: OPACAssignee: Owen Leonard <oleonard>
Status: CLOSED INVALID QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low    
Version: Main   
Hardware: All   
OS: All   
GIT URL: Initiative type: ---
Sponsorship status: --- Comma delimited list of Sponsors:
Crowdfunding goal: 0 Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Description David Cook 2024-05-27 02:13:17 UTC
At the moment, the self-registration won't work without PatronSelfRegistrationDefaultCategory but technically if you don't have categorycode hidden, then it should be unnecessary.
Comment 1 Owen Leonard 2024-07-02 17:44:15 UTC
The template has markup to handle a situation where categorycode ISN'T hidden, but in opac.pref categorycode and dateexpiry are both hard-coded to be hidden.
Comment 2 David Cook 2024-07-04 00:24:07 UTC
(In reply to Owen Leonard from comment #1)
> The template has markup to handle a situation where categorycode ISN'T
> hidden, but in opac.pref categorycode and dateexpiry are both hard-coded to
> be hidden.

Ah right. This is probably one of those bugs that happens because of local customizations of mine ﷐[U+1F605]﷑. In some cases, we allow people to choose from a limited number of category codes, and new self-registered patrons are blocked by default, so they have to be reviewed and approved before being enabled. 

I tell myself one day I'll upstream all the things...