| Summary: | PUT for patrons requires full borrowers permission, but should only require 'edit_borrowers' | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | REST API | Assignee: | Bugs List <koha-bugs> |
| Status: | Needs Signoff --- | QA Contact: | |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | kyle, rcoert, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37228 | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 36988: Change permission
Bug 36988: Update unit tests Bug 36988: Change permission Bug 36988: Update unit tests Bug 36988: Update unit tests |
||
|
Description
Nick Clemens (kidclamp)
2024-05-29 17:48:00 UTC
Created attachment 167270 [details] [review] Bug 36988: Change permission Created attachment 167271 [details] [review] Bug 36988: Update unit tests Unit tests fail if given only edit_borrowers permission. Created attachment 167272 [details] [review] Bug 36988: Change permission Created attachment 167273 [details] [review] Bug 36988: Update unit tests Created attachment 188660 [details] [review] Bug 36988: Update unit tests These highlight why we may have made this choice. With only 'edit_borrowers' you can make changes, but you cannot view your changes as you aren't allowed to see other borrowers. Test now pass, but not sure if this answers the question of why we did it this way, or if there is more work here. Should you be able to get back the fields that you updated at the least, to confirm your changes? Or should we send a success with a message that you can't see the data? |