Summary: | Correct several HTML markup errors | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | RESOLVED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | david, fridolin.somers, lucas, matt.blenkinsop |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This fixes several minor HTML markup validation errors for the bibliographic detail page in the staff interface.
|
Version(s) released in: |
24.11.00,24.05.02
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 33195 | ||
Attachments: |
Bug 37002: Correct several HTML markup errors
Bug 37002: Correct several HTML markup errors Bug 37002: Correct several HTML markup errors |
Description
Owen Leonard
2024-05-31 13:13:23 UTC
Created attachment 167310 [details] [review] Bug 37002: Correct several HTML markup errors This patch makes several minor corrections to HTML markup in the bibliographic detail page template and related include files. This corrects the following validator errors: - Stray end tag a. - Bad value true for attribute disabled on element select. - Bad value true for attribute disabled on element input. - No space between attributes. - Duplicate attribute class. - The value of the for attribute of the label element must be the ID of a non-hidden form control. The patch is simple enough that an inspection of the patch is probably enough, but following is a detailed test plan of the affected areas: - Apply the patch and view the bibliographic detail page in the staff interface. - Under the "Edit" menu in the toolbar, these options should still work correctly: - Modify record using template - Edit items in a batch - Delete items in a batch - Click the "Items" link in the sidebar and find the "Bookable" setting for the title's items. Make at least one item bookable and return to the detail page. - Click the "Place booking" button in the toolbar and confirm that you can successfully place the booking. - If you have access to Novelist, confirm that Novelist content displays correctly on the detail page. - Turn on the "EnableItemGroups" preference. - On the detail page, open the "Item groups" tab and click the "New item group" button. - In the modal, the "Name" and "Display order" labels give focus to the corresponding form field when clicked. - Create an item group. - Under the holdings tab, select one or more items and click "Add/move to item group". - In the modal, clicking the "Item group" label should give focus to the dropdown. Created attachment 167316 [details] [review] Bug 37002: Correct several HTML markup errors This patch makes several minor corrections to HTML markup in the bibliographic detail page template and related include files. This corrects the following validator errors: - Stray end tag a. - Bad value true for attribute disabled on element select. - Bad value true for attribute disabled on element input. - No space between attributes. - Duplicate attribute class. - The value of the for attribute of the label element must be the ID of a non-hidden form control. The patch is simple enough that an inspection of the patch is probably enough, but following is a detailed test plan of the affected areas: - Apply the patch and view the bibliographic detail page in the staff interface. - Under the "Edit" menu in the toolbar, these options should still work correctly: - Modify record using template - Edit items in a batch - Delete items in a batch - Click the "Items" link in the sidebar and find the "Bookable" setting for the title's items. Make at least one item bookable and return to the detail page. - Click the "Place booking" button in the toolbar and confirm that you can successfully place the booking. - If you have access to Novelist, confirm that Novelist content displays correctly on the detail page. - Turn on the "EnableItemGroups" preference. - On the detail page, open the "Item groups" tab and click the "New item group" button. - In the modal, the "Name" and "Display order" labels give focus to the corresponding form field when clicked. - Create an item group. - Under the holdings tab, select one or more items and click "Add/move to item group". - In the modal, clicking the "Item group" label should give focus to the dropdown. Signed-off-by: David Nind <david@davidnind.com> Created attachment 167357 [details] [review] Bug 37002: Correct several HTML markup errors This patch makes several minor corrections to HTML markup in the bibliographic detail page template and related include files. This corrects the following validator errors: - Stray end tag a. - Bad value true for attribute disabled on element select. - Bad value true for attribute disabled on element input. - No space between attributes. - Duplicate attribute class. - The value of the for attribute of the label element must be the ID of a non-hidden form control. The patch is simple enough that an inspection of the patch is probably enough, but following is a detailed test plan of the affected areas: - Apply the patch and view the bibliographic detail page in the staff interface. - Under the "Edit" menu in the toolbar, these options should still work correctly: - Modify record using template - Edit items in a batch - Delete items in a batch - Click the "Items" link in the sidebar and find the "Bookable" setting for the title's items. Make at least one item bookable and return to the detail page. - Click the "Place booking" button in the toolbar and confirm that you can successfully place the booking. - If you have access to Novelist, confirm that Novelist content displays correctly on the detail page. - Turn on the "EnableItemGroups" preference. - On the detail page, open the "Item groups" tab and click the "New item group" button. - In the modal, the "Name" and "Display order" labels give focus to the corresponding form field when clicked. - Create an item group. - Under the holdings tab, select one or more items and click "Add/move to item group". - In the modal, clicking the "Item group" label should give focus to the dropdown. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Current status: Signed Off Lucas did you mean to do a second sign off or was it supposed to be a PQA? Picked from QA queue for main. Pushed for 24.11! Well done everyone, thank you! Backported to 24.05.x for upcoming 24.05.02 Does not apply on 23.11.x Maybe not needed |