| Summary: | "Help" link on ERM pages is not translatable | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
| Component: | ERM | Assignee: | Katrin Fischer <katrin.fischer> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | f.demians, fridolin.somers, jake.deery, jonathan.druart, jonathan.field, lucas, martin.renvoize, matt.blenkinsop, pedro.amorim |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
24.11.00,24.05.06
|
|
| Circulation function: | |||
| Attachments: |
Bug 37008: Make "Help" link in vue modules translatable
Bug 37008: Make "Help" link in vue modules translatable Bug 37008: Make "Help" link in vue modules translatable |
||
|
Description
Katrin Fischer
2024-06-02 10:40:48 UTC
Created attachment 168207 [details] [review] Bug 37008: Make "Help" link in vue modules translatable The "Help" link in the upper right corner was not translatable in the newer vue modules like ERM and Preservation. To test in koha-testing-docker: * Install any language: sudo koha-translate --install de-DE --dev kohadev * Activate the language in the language system preference * Activate the ERMModule system preference * Go to the ERM module, verify translation works in general, but Help remains in English * Apply patch * Run: yarn build * Run: gulp po:update * Verify the string "Help" now appears in misc/translator/po/de-DE-messages-js.po * Translate it * Run: sudo koha-translate --update de-DE --dev kohadev * Verify "Help" is now translated Created attachment 168208 [details] [review] Bug 37008: Make "Help" link in vue modules translatable The "Help" link in the upper right corner was not translatable in the newer vue modules like ERM and Preservation. To test in koha-testing-docker: * Install any language: sudo koha-translate --install de-DE --dev kohadev * Activate the language in the language system preference * Activate the ERMModule system preference * Go to the ERM module, verify translation works in general, but Help remains in English * Apply patch * Run: yarn build * Run: gulp po:update * Verify the string "Help" now appears in misc/translator/po/de-DE-messages-js.po * Translate it * Run: sudo koha-translate --update de-DE --dev kohadev * Verify "Help" is now translated @Katrin should this be "Needs Sign-off"? (In reply to Pedro Amorim from comment #3) > @Katrin should this be "Needs Sign-off"? It definitely should be, thanks Pedro. Just for info: I am currently going through all the ERM templates, so more fixes coming soon (I need to do some more testing, where I was not sure) Created attachment 168321 [details] [review] Bug 37008: Make "Help" link in vue modules translatable The "Help" link in the upper right corner was not translatable in the newer vue modules like ERM and Preservation. To test in koha-testing-docker: * Install any language: sudo koha-translate --install de-DE --dev kohadev * Activate the language in the language system preference * Activate the ERMModule system preference * Go to the ERM module, verify translation works in general, but Help remains in English * Apply patch * Run: yarn build * Run: gulp po:update * Verify the string "Help" now appears in misc/translator/po/de-DE-messages-js.po * Translate it * Run: sudo koha-translate --update de-DE --dev kohadev * Verify "Help" is now translated Signed-off-by: Jake Deery <jake.deery@ptfs-europe.com> Thanks Jake! Looks great to me, confirmed it as working following the test plan -- initially, added a translation string manually to misc/translator/po/es-ES-messages-js.po: 3617 #: koha-tmpl/intranet-tmpl/prog/js/vue/components/Help.vue:9 3618 msgid "Help" 3619 msgstr "Ayuda" <-- was just "" I would suspect this was because the string isn't in Weblate, yet. Nonetheless, when I added Ayuda and switched to Spanish, I could see the string correctly translated. Might want a second opinion on whether this is correct at the QA stage, but am happy to sign off as I feel the behaviour is accurate (I'm new to Koha dev, see!) Signed off with thanks Picked from QA queue for push to main. Pushed for 24.11! Well done everyone, thank you! Backported to 24.05.x for upcoming 24.05.06 Not for 23.11.x ? |