Summary: | "Item was not checked in" printed on next POST because of missing supplementary form | ||
---|---|---|---|
Product: | Koha | Reporter: | Andrii Nugged <nugged> |
Component: | Circulation | Assignee: | Andrii Nugged <nugged> |
Status: | RESOLVED FIXED | QA Contact: | Lucas Gass (lukeg) <lucas> |
Severity: | normal | ||
Priority: | P3 | CC: | andreas.jonsson, andrew, Chip.Halvorsen, david, fridolin.somers, gmcharlt, holly, kebliss, kyle, laura, lucas, mnero, wainuiwitikapark |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: |
This fixes a check in issue where the message "Item was not checked in" was appearing in the due date column of the checked-in items table. This was occurring when an action was required for an item after it was checked in, for example when the item needed transferring to another library.
|
|
Version(s) released in: |
24.11.00,24.05.02,23.11.07
|
Circulation function: | |
Bug Depends on: | 8461 | ||
Bug Blocks: | |||
Attachments: |
(screenshot and diagram of a potential bug)
Bug 37014: Fix after-modal-POST to transmit "not_returned" message Bug 37014: Fix after-modal-POST to transmit "not_returned" message Bug 37014: Fix after-modal-POST to transmit "not_returned" message Bug 37014: Fix after-modal-POST to transmit "not_returned" message |
Created attachment 167335 [details] [review] Bug 37014: Fix after-modal-POST to transmit "not_returned" message The bug report addresses an issue where the message "Item was not checked in" erroneously appears during the second POST after a manual or modal check-in process. 1. In circ/returns.pl: - IntrIntroduced a new hash `%rinot_returned` to track items not returned across pages. - Updated the logic to capture the "not returned" status from the query parameters. - Adjusted the input processing loop to include `not_returned` status. - Modified the section handling barcode check-ins to appropriately initialize and update the `not_returned` status. 2. returns.tt: - Added hidden input fields in the template to include `not_returned` status in the form submissions. The changes ensure that the "not_returned" status is correctly tracked and displayed, preventing the erroneous message from appearing on subsequent POST requests. 1. Perform a manual check-in of an item, but make some warning modal appear: for ex., transfer: check-in the item in not home library. 2. Press OK on the modal. There will be a POST transition again to redraw the checked-in items list. 3. Verify that the "Item was not checked in" message appears erroneously near the item's row. 4. Apply the patch. 5. Repeat steps 1-3 and check that there will be no erroneous "Item was not checked in" message. Created attachment 167336 [details] [review] Bug 37014: Fix after-modal-POST to transmit "not_returned" message The bug report addresses an issue where the message "Item was not checked in" erroneously appears during the second POST after a manual or modal check-in process. 1. In circ/returns.pl: - Introduced a new hash `%rinot_returned` to track items not returned across pages. - Updated the logic to capture the "not returned" status from the query parameters. - Adjusted the input processing loop to include `not_returned` status. - Modified the section handling barcode check-ins to appropriately initialize and update the `not_returned` status. 2. returns.tt: - Added hidden input fields in the template to include `not_returned` status in the form submissions. The changes ensure that the "not_returned" status is correctly tracked and displayed, preventing the erroneous message from appearing on subsequent POST requests. 1. Perform a manual check-in of an item, but make some warning modal appear: for ex., transfer: check-in the item in not home library. 2. Press OK on the modal. There will be a POST transition again to redraw the checked-in items list. 3. Verify that the "Item was not checked in" message appears erroneously near the item's row. 4. Apply the patch. 5. Repeat steps 1-3 and check that there will be no erroneous "Item was not checked in" message. Created attachment 167341 [details] [review] Bug 37014: Fix after-modal-POST to transmit "not_returned" message The bug report addresses an issue where the message "Item was not checked in" erroneously appears during the second POST after a manual or modal check-in process. 1. In circ/returns.pl: - Introduced a new hash `%rinot_returned` to track items not returned across pages. - Updated the logic to capture the "not returned" status from the query parameters. - Adjusted the input processing loop to include `not_returned` status. - Modified the section handling barcode check-ins to appropriately initialize and update the `not_returned` status. 2. returns.tt: - Added hidden input fields in the template to include `not_returned` status in the form submissions. The changes ensure that the "not_returned" status is correctly tracked and displayed, preventing the erroneous message from appearing on subsequent POST requests. 1. Perform a manual check-in of an item, but make some warning modal appear: for ex., transfer: check-in the item in not home library. 2. Press OK on the modal. There will be a POST transition again to redraw the checked-in items list. 3. Verify that the "Item was not checked in" message appears erroneously near the item's row. 4. Apply the patch. 5. Repeat steps 1-3 and check that there will be no erroneous "Item was not checked in" message. Signed-off-by: Tadeusz „tadzik” Sośnierz <tadeusz@sosnierz.com> We have started to see this since the upgrade to 23.11.06. I think this should be given a higher priority as the faulty message is confusing and annoying. Created attachment 167940 [details] [review] Bug 37014: Fix after-modal-POST to transmit "not_returned" message The bug report addresses an issue where the message "Item was not checked in" erroneously appears during the second POST after a manual or modal check-in process. 1. In circ/returns.pl: - Introduced a new hash `%rinot_returned` to track items not returned across pages. - Updated the logic to capture the "not returned" status from the query parameters. - Adjusted the input processing loop to include `not_returned` status. - Modified the section handling barcode check-ins to appropriately initialize and update the `not_returned` status. 2. returns.tt: - Added hidden input fields in the template to include `not_returned` status in the form submissions. The changes ensure that the "not_returned" status is correctly tracked and displayed, preventing the erroneous message from appearing on subsequent POST requests. 1. Perform a manual check-in of an item, but make some warning modal appear: for ex., transfer: check-in the item in not home library. 2. Press OK on the modal. There will be a POST transition again to redraw the checked-in items list. 3. Verify that the "Item was not checked in" message appears erroneously near the item's row. 4. Apply the patch. 5. Repeat steps 1-3 and check that there will be no erroneous "Item was not checked in" message. Signed-off-by: Tadeusz „tadzik” Sośnierz <tadeusz@sosnierz.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Pushed for 24.11! Well done everyone, thank you! Could this be backported to 24.05? The patch applies without issues on 23.11.06. *** Bug 37296 has been marked as a duplicate of this bug. *** Backported to 24.05.x for upcomin 24.05.02 Pushed to 23.11.x for 23.11.07 not backporting to 23.05.x unless requested Not backporting to 22.11 unless requested Bug fix, nothing to change in the manual |
Created attachment 167332 [details] (screenshot and diagram of a potential bug) This "not_returned" feature computation logic and: [% IF ( riloo.not_returned ) %] <span class="problem">Item was not checked in</span> [% END %] Our production servers started to show "Item was not checked in" for items that had just been checked in (also for manual check-in). I noticed that this happens on the second load. I.e., when there was a modal, grayed-out content under modal is shown correctly: there is no "not checked in" message, but then circ/returns.pl page reloaded, form POST'ed again, and on next screen, it shows this "not checked in" additional message, on the next after modal, page.