Bug 37023

Summary: Filling a hold should update the timestamp
Product: Koha Reporter: Johanna Räisä <johanna.raisa>
Component: CirculationAssignee: Johanna Räisä <johanna.raisa>
Status: Pushed to main --- QA Contact: Lucas Gass (lukeg) <lucas>
Severity: enhancement    
Priority: P5 - low CC: gmcharlt, kebliss, kyle.m.hall, lucas, martin.renvoize
Version: MainKeywords: release-notes-needed
Hardware: All   
OS: All   
Change sponsored?: Sponsored Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00
Circulation function: holds
Attachments: Bug 37023: Update timestamp when filling a hold
Bug 37023: Update timestamp when filling a hold
Bug 37023: Update timestamp when filling a hold

Description Johanna Räisä 2024-06-04 10:28:25 UTC
At the moment when a hold is filled the timestamp on database doesn't get updated. The row in the reserves table is copied to old_reserves and it is filled with the same timestamp value as before.
Comment 1 Johanna Räisä 2024-06-04 11:50:21 UTC
Created attachment 167378 [details] [review]
Bug 37023: Update timestamp when filling a hold

This patch updates the timestamp of the hold when it is filled and moved to old_reserves.

Test plan:
1) Apply the patch
2) prove t/db_dependent/Koha/Hold.t

Sponsored-by: Koha-Suomi Oy
Comment 2 Matt Blenkinsop 2024-06-05 15:43:39 UTC
Created attachment 167457 [details] [review]
Bug 37023: Update timestamp when filling a hold

This patch updates the timestamp of the hold when it is filled and moved to old_reserves.

Test plan:
1) Apply the patch
2) prove t/db_dependent/Koha/Hold.t

Sponsored-by: Koha-Suomi Oy
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Comment 3 Lucas Gass (lukeg) 2024-09-23 22:35:18 UTC
Trivial change, does what it is suppose to, includes tests to prove the chane, QA script is happy.
Comment 4 Lucas Gass (lukeg) 2024-09-23 22:38:40 UTC
Created attachment 171904 [details] [review]
Bug 37023: Update timestamp when filling a hold

This patch updates the timestamp of the hold when it is filled and moved to old_reserves.

Test plan:
1) Apply the patch
2) prove t/db_dependent/Koha/Hold.t

Sponsored-by: Koha-Suomi Oy
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 5 Katrin Fischer 2024-10-16 12:58:05 UTC
This is probably a bug, but maybe the change is better for a major release?
Comment 6 Katrin Fischer 2024-10-21 10:27:18 UTC
Pushed for 24.11!

Well done everyone, thank you!