Bug 37027

Summary:	Some dataTable controls in SCO seem unnecessary
Product:	Koha	Reporter:	Lucas Gass (lukeg) <lucas>
Component:	Self checkout	Assignee:	Lucas Gass (lukeg) <lucas>
Status:	Pushed to main ---	QA Contact:	Martin Renvoize (ashimema) <martin.renvoize>
Severity:	normal
Priority:	P5 - low
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	24.11.00
Circulation function:
Bug Depends on:	35007, 37026
Bug Blocks:
Attachments:	Bug 37027: Remove unnecessary dataTable controls from SCO tables Bug 37027: Remove unnecessary dataTable controls from SCO tables Bug 37027: Remove unnecessary dataTable controls from SCO tables

Description Lucas Gass (lukeg) 2024-06-04 14:33:47 UTC

To recreate:

1. Have a patron with some checkouts, holds, and charges that can login into the SCO module.
2. Notice the dataTable controls for searching the table, copying the table, exporting as CSV, or printing.
3. In my opinion the only nessesary function here is searching the table.

Comment 1 Lucas Gass (lukeg) 2024-06-04 14:36:21 UTC

Created attachment 167398 [details] [review]
Bug 37027: Remove unnecessary dataTable controls from SCO tables

To test:
1. Have a patron with some checkouts, holds, and charges that can login into the SCO module.
2. Notice the dataTable controls for searching the table, copying the table, exporting as CSV, or printing.
3. APPLY PATCH
4. Try step 2 again, this time the only dataTable control should be the search filter.

Comment 2 Sam Lau 2024-06-04 16:22:06 UTC

Created attachment 167405 [details] [review]
Bug 37027: Remove unnecessary dataTable controls from SCO tables

To test:
1. Have a patron with some checkouts, holds, and charges that can login into the SCO module.
2. Notice the dataTable controls for searching the table, copying the table, exporting as CSV, or printing.
3. APPLY PATCH
4. Try step 2 again, this time the only dataTable control should be the search filter.

Signed-off-by: Sam Lau <samalau@gmail.com>

Comment 3 Martin Renvoize (ashimema) 2024-07-01 15:54:38 UTC

Created attachment 168325 [details] [review]
Bug 37027: Remove unnecessary dataTable controls from SCO tables

To test:
1. Have a patron with some checkouts, holds, and charges that can login into the SCO module.
2. Notice the dataTable controls for searching the table, copying the table, exporting as CSV, or printing.
3. APPLY PATCH
4. Try step 2 again, this time the only dataTable control should be the search filter.

Signed-off-by: Sam Lau <samalau@gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Comment 4 Martin Renvoize (ashimema) 2024-07-01 15:54:59 UTC

Thanks, looks better now.

Passing QA

Comment 5 Katrin Fischer 2024-07-02 08:05:03 UTC

Am I the only one really struggling with that datatables syntax? :)

Comment 6 Katrin Fischer 2024-07-02 08:21:22 UTC

Pushed for 24.11!

Well done everyone, thank you!