Bug 37030

Summary: Use template wrapper for breadcrumbs: Cash register stats
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: Pushed to oldstable --- QA Contact: Marcel de Rooy <m.de.rooy>
Severity: minor    
Priority: P5 - low CC: david, fridolin.somers, lucas, m.de.rooy, testopia, wainuiwitikapark
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00,24.05.04,23.11.09
Circulation function:
Bug Depends on: 33436    
Bug Blocks: 35402    
Attachments: Bug 37030: Use template wrapper for breadcrumbs: Cash register stats
Bug 37030: Use template wrapper for breadcrumbs: Cash register stats
Bug 37030: Use template wrapper for breadcrumbs: Cash register stats

Description Owen Leonard 2024-06-04 17:05:49 UTC
This fix was supposed to be in Bug 33436 but I apparently missed it!
Comment 1 Owen Leonard 2024-06-04 18:13:15 UTC
Created attachment 167411 [details] [review]
Bug 37030: Use template wrapper for breadcrumbs: Cash register stats

This patch updates the cash register statistics template so that they
use the new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Reports ->
  - Cash register statistics
    - Results

Sponsored-By: Athens County Public Libraries
Comment 2 David Nind 2024-06-04 19:05:13 UTC
Created attachment 167418 [details] [review]
Bug 37030: Use template wrapper for breadcrumbs: Cash register stats

This patch updates the cash register statistics template so that they
use the new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Reports ->
  - Cash register statistics
    - Results

Sponsored-By: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Marcel de Rooy 2024-08-02 09:31:35 UTC
Created attachment 169995 [details] [review]
Bug 37030: Use template wrapper for breadcrumbs: Cash register stats

This patch updates the cash register statistics template so that they
use the new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Reports ->
  - Cash register statistics
    - Results

Sponsored-By: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Katrin Fischer 2024-08-02 17:01:26 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 5 Lucas Gass (lukeg) 2024-09-11 15:54:55 UTC
Backported to 24.05.x for upcoming 24.05.04
Comment 6 Fridolin Somers 2024-09-25 08:36:36 UTC
Pushed to 23.11.x for 23.11.09
Comment 7 Wainui Witika-Park 2024-09-27 02:20:34 UTC
IS this okay to backport during string freeze?