|
Description
Kyle M Hall (khall)
2024-06-05 14:53:06 UTC
Created attachment 167444 [details] [review] Bug 37035: Merging authorities triggers rebuilding holds for all affected records when RealTimeHoldsQueue is enabled If RealTimeHoldsQueue is on, merging authorities triggers a update_holds_queue_for_biblios background job for each affected record. This can result in thousands of unnecessary queued jobs since this change will not affect hold-ability. In a large catalog this can be a crippling number of background jobs that will delay more important jobs. Test Plan: 1) Enable RealTimeHoldsQueue 2) Merge authorities with merge_authorities.pl 3) Note a update_holds_queue_for_biblios background job is queued for each record touched 4) Apply this match 5) Merge authorities again 6) Note that no update_holds_queue_for_biblios jobs were queued Created attachment 167445 [details] [review] Bug 37035: Merging authorities triggers rebuilding holds for all affected records when RealTimeHoldsQueue is enabled If RealTimeHoldsQueue is on, merging authorities triggers a update_holds_queue_for_biblios background job for each affected record. This can result in thousands of unnecessary queued jobs since this change will not affect hold-ability. In a large catalog this can be a crippling number of background jobs that will delay more important jobs. Test Plan: 1) Enable RealTimeHoldsQueue 2) Merge authorities with merge_authorities.pl 3) Note a update_holds_queue_for_biblios background job is queued for each record touched 4) Apply this match 5) Merge authorities again 6) Note that no update_holds_queue_for_biblios jobs were queued Created attachment 167456 [details] [review] Bug 37035: Merging authorities triggers rebuilding holds for all affected records when RealTimeHoldsQueue is enabled If RealTimeHoldsQueue is on, merging authorities triggers a update_holds_queue_for_biblios background job for each affected record. This can result in thousands of unnecessary queued jobs since this change will not affect hold-ability. In a large catalog this can be a crippling number of background jobs that will delay more important jobs. Test Plan: 1) Enable RealTimeHoldsQueue 2) Merge authorities with merge_authorities.pl 3) Note a update_holds_queue_for_biblios background job is queued for each record touched 4) Apply this match 5) Merge authorities again 6) Note that no update_holds_queue_for_biblios jobs were queued Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Small, logical change. Code looks good and QA tool passes. Passing QA Created attachment 167662 [details] [review] Bug 37035: Merging authorities triggers rebuilding holds for all affected records when RealTimeHoldsQueue is enabled If RealTimeHoldsQueue is on, merging authorities triggers a update_holds_queue_for_biblios background job for each affected record. This can result in thousands of unnecessary queued jobs since this change will not affect hold-ability. In a large catalog this can be a crippling number of background jobs that will delay more important jobs. Test Plan: 1) Enable RealTimeHoldsQueue 2) Merge authorities with merge_authorities.pl 3) Note a update_holds_queue_for_biblios background job is queued for each record touched 4) Apply this match 5) Merge authorities again 6) Note that no update_holds_queue_for_biblios jobs were queued Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Any chance of a unit test here Kyle? Prevent a future regression and all that ;P |