| Summary: | touch_all_biblios.pl triggers rebuilding holds for all affected records when RealTimeHoldsQueue is enabled | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
| Component: | Architecture, internals, and plumbing | Assignee: | Kyle M Hall (khall) <kyle> |
| Status: | Pushed to oldstable --- | QA Contact: | Emily Lamancusa (emlam) <emily.lamancusa> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | david, emily.lamancusa, fridolin.somers, kyle, lucas, wainuiwitikapark |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37035 | ||
| Change sponsored?: | --- | Patch complexity: | String patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This fixes running misc/maintenance/touch_all_biblios.pl when RealTimeHoldsQueue is enabled - it was creating background jobs to rebuild the holds queue for every record, which was unnecessary.
|
Version(s) released in: |
24.11.00,24.05.02,23.11.07
|
| Circulation function: | |||
| Attachments: |
Bug 37037: touch_all_biblios.pl triggers rebuilding holds for all affected records when RealTimeHoldsQueue is enabled
Bug 37037: touch_all_biblios.pl triggers rebuilding holds for all affected records when RealTimeHoldsQueue is enabled Bug 37037: touch_all_biblios.pl triggers rebuilding holds for all affected records when RealTimeHoldsQueue is enabled |
||
|
Description
Kyle M Hall (khall)
2024-06-05 15:04:12 UTC
Created attachment 167450 [details] [review] Bug 37037: touch_all_biblios.pl triggers rebuilding holds for all affected records when RealTimeHoldsQueue is enabled If RealTimeHoldsQueue is on, touch_all_biblios triggers a update_holds_queue_for_biblios background job for each affected record. This will result in a as many background jobs being queued up as records! It makes far more sense for this script to not do that which gives the administrator the option for running the holds queue builder if the changes would affect holdability, or to not run it at all. Test Plan: 1) Run touch_all_biblios.pl 3) Note a update_holds_queue_for_biblios background job is queued for each record touched 4) Apply this patch 5) Merge touch_all_biblios.pl again 6) Note that no update_holds_queue_for_biblios jobs were queued Created attachment 167455 [details] [review] Bug 37037: touch_all_biblios.pl triggers rebuilding holds for all affected records when RealTimeHoldsQueue is enabled If RealTimeHoldsQueue is on, touch_all_biblios triggers a update_holds_queue_for_biblios background job for each affected record. This will result in a as many background jobs being queued up as records! It makes far more sense for this script to not do that which gives the administrator the option for running the holds queue builder if the changes would affect holdability, or to not run it at all. Test Plan: 1) Run touch_all_biblios.pl 3) Note a update_holds_queue_for_biblios background job is queued for each record touched 4) Apply this patch 5) Merge touch_all_biblios.pl again 6) Note that no update_holds_queue_for_biblios jobs were queued Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Created attachment 167660 [details] [review] Bug 37037: touch_all_biblios.pl triggers rebuilding holds for all affected records when RealTimeHoldsQueue is enabled If RealTimeHoldsQueue is on, touch_all_biblios triggers a update_holds_queue_for_biblios background job for each affected record. This will result in a as many background jobs being queued up as records! It makes far more sense for this script to not do that which gives the administrator the option for running the holds queue builder if the changes would affect holdability, or to not run it at all. Test Plan: 1) Run touch_all_biblios.pl 3) Note a update_holds_queue_for_biblios background job is queued for each record touched 4) Apply this patch 5) Merge touch_all_biblios.pl again 6) Note that no update_holds_queue_for_biblios jobs were queued Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Small, logical change. QA tool is happy. Passing QA As this is a script and not a module, I'm not worried about a unit test here... but a warning at the end of the script run might be nice to give whoever ran the script a heads up that they may want to now run a rebuild of the holds queue might be helpful? Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant Backported to 24.05.x for upcoming 24.05.02 Pushed to 23.11.x for 23.11.07 not backporting to 23.05.x unless requested |