Bug 37046

Summary: Use template wrapper for OPAC curbside pickup tabs
Product: Koha Reporter: Owen Leonard <oleonard>
Component: OPACAssignee: Owen Leonard <oleonard>
Status: Pushed to main --- QA Contact: Katrin Fischer <katrin.fischer>
Severity: enhancement    
Priority: P5 - low    
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00
Circulation function:
Bug Depends on: 32571    
Bug Blocks:    
Attachments: Bug 37046: Use template wrapper for OPAC curbside pickups
Bug 37046: Use template wrapper for OPAC curbside pickups
Bug 37046: Use template wrapper for OPAC curbside pickups
Bug 37046: Use template wrapper for OPAC curbside pickup tabs

Description Owen Leonard 2024-06-06 16:04:07 UTC
Continuing the work of Bug 32571, OPAC's curbside pickups page should be updated to use the new WRAPPER for tabs.
Comment 1 Owen Leonard 2024-06-06 16:45:03 UTC
Created attachment 167553 [details] [review]
Bug 37046: Use template wrapper for OPAC curbside pickups

This patch updates the OPAC curbside pickups template to use WRAPPERs
for the Bootstrap tabs markup.

To test, apply the patch and enable the "CurbsidePickup" system
preference if necessary.

- Log in to the OPAC and click the "Curbside pickups" tab in the sidebar
  of the user summary page.
  - With no curbside pickup policy defined, you shoul see a single tab,
    "Your pickups" and the message "No curbside pickups."
- In the staff interface go to Administration -> Curbside pickup.
  - Configure curbside pickups for at least one branch.
- Return to the OPAC and refresh the curbside pickups page.
  - You should now see a "Schedule a pickup" tab along with the "Your
    pickups" tab, and it should be active by default.
  - Schedule a pickup.
    - When the page refreshes, the "Your pickups" tab should now be
      active by default.

Sponsored-By: Athens County Public Libraries
Comment 2 David Nind 2024-06-06 21:13:33 UTC Comment hidden (obsolete)
Comment 3 Owen Leonard 2024-08-23 18:00:18 UTC
Created attachment 170660 [details] [review]
Bug 37046: Use template wrapper for OPAC curbside pickups

This patch updates the OPAC curbside pickups template to use WRAPPERs
for the Bootstrap tabs markup.

To test, apply the patch and enable the "CurbsidePickup" system
preference if necessary.

- Log in to the OPAC and click the "Curbside pickups" tab in the sidebar
  of the user summary page.
  - With no curbside pickup policy defined, you shoul see a single tab,
    "Your pickups" and the message "No curbside pickups."
- In the staff interface go to Administration -> Curbside pickup.
  - Configure curbside pickups for at least one branch.
- Return to the OPAC and refresh the curbside pickups page.
  - You should now see a "Schedule a pickup" tab along with the "Your
    pickups" tab, and it should be active by default.
  - Schedule a pickup.
    - When the page refreshes, the "Your pickups" tab should now be
      active by default.

Sponsored-By: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Comment 4 Owen Leonard 2024-08-30 14:24:38 UTC
Created attachment 170912 [details] [review]
Bug 37046: Use template wrapper for OPAC curbside pickup tabs

This patch updates the OPAC curbside pickups template to use WRAPPERs
for the Bootstrap tabs markup.

To test, apply the patch and enable the "CurbsidePickup" system
preference if necessary.

- Log in to the OPAC and click the "Curbside pickups" tab in the sidebar
  of the user summary page.
  - With no curbside pickup policy defined, you shoul see a single tab,
    "Your pickups" and the message "No curbside pickups."
- In the staff interface go to Administration -> Curbside pickup.
  - Configure curbside pickups for at least one branch.
- Return to the OPAC and refresh the curbside pickups page.
  - You should now see a "Schedule a pickup" tab along with the "Your
    pickups" tab, and it should be active by default.
  - Schedule a pickup.
    - When the page refreshes, the "Your pickups" tab should now be
      active by default.

Sponsored-By: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Comment 5 Katrin Fischer 2024-09-02 09:46:35 UTC
Time to finish this project :) QA'd by RM.
Comment 6 Katrin Fischer 2024-09-02 10:21:24 UTC
Pushed for 24.11!

Well done everyone, thank you!