| Summary: | Spurious CSRF error logged by 500.pl when a POST request fails | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | Architecture, internals, and plumbing | Assignee: | Bugs List <koha-bugs> |
| Status: | RESOLVED DUPLICATE | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | dcook, jonathan.druart, kyle, martin.renvoize |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
Can you check it out and let me know what you think? |
I haven't been able to set things up to recreate on KTD, but in production: 1 - Set an email for a patron and enable HOLD notifications 2 - Edit the HOLD letter to use a spurious item field [% item.itemcopynumber %] 3 - Place a hold for patron and confirm 4 - Error in logs ERROR PROCESSING TEMPLATE: undef error - The method Koha::Item->itemcopynumber is not covered by tests! 5 - But also: [WARN] Programming error - op 'cud-affect_reserve' must not start with 'cud-' for GET https://staff-library.provider.com/intraneterrors/500.pl (referer: https://staff-library.provider.com/cgi-bin/koha/circ/returns.pl) at /usr/share/koha/lib/Koha/Middleware/CSRF.pm line 82. 6 - The ErrorDocument middleware automatically transforms every request into a GET - so suddenly the cud- op is rejected