Summary: | Incorrect barcode generation when adding orders to basket | ||
---|---|---|---|
Product: | Koha | Reporter: | Hammat wele <hammat.wele> |
Component: | Acquisitions | Assignee: | Hammat wele <hammat.wele> |
Status: | Needs documenting --- | QA Contact: | Kyle M Hall (khall) <kyle> |
Severity: | minor | ||
Priority: | P5 - low | CC: | caroline.cyr-la-rose, fridolin.somers, kyle, lucas, philippe.blouin |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
24.11.00,24.05.06
|
|
Circulation function: | |||
Attachments: |
Bug 37070: Incorrect barcode generation when adding orders to basket
Bug 37070: Incorrect barcode generation when adding orders to basket Bug 37070: Incorrect barcode generation when adding orders to basket Bug 37070: (QA follow-up) Fix qa script issues |
Description
Hammat wele
2024-06-11 12:52:05 UTC
Comment hidden (obsolete)
When the autoBarcode preference is set to « generated in the form 1, 2, 3 » and the maximum barcode is length 16 (ex 1000000000000000), when adding orders to the basket,the numbers of the copies generated are in the hexadecimal form. to reproduce: 1- Set the system preference autoBarcode to « generated in the form 1, 2, 3 » 2- Search for a biblio record 3- In the record details, click on New -> New item 4- fill the Barcode field to a number with length 16 (1000000000000000) and add the item 5- Create a suggestion 5-1- Go to Acquisitions and click on suggestions 5-2- Create a suggestion and accept it 6- Add a new order to a basket 6-1- Go to Acquisitions and find a vendor 6-2- Create a new Basket 6-3- on the Basket click on 'Add to basket' and select 'From a suggestion' 6-4- Add the order created on 5-2- to the basket 6-5- On the item form click on Add item 6-6- Select a Fund and save the order 7- In the orders table click on the record and check the item Barcode ---> the Barcode is in hexadecimal form 8- Cancel order and delete the catalog record Created attachment 167634 [details] [review] Bug 37070: Incorrect barcode generation when adding orders to basket When the autoBarcode preference is set to « generated in the form 1, 2, 3 » and the maximum barcode is length 16 (ex 1000000000000000), when adding orders to the basket,the numbers generated are in the hexadecimal form. to reproduce: 1- Set the system preference autoBarcode to « generated in the form 1, 2, 3 » 2- Search for a biblio record 3- In the record details, click on New -> New item 4- fill the Barcode field to a number with length 16 (1000000000000000) and add the item 5- Create a suggestion 5-1- Go to Acquisitions and click on suggestions 5-2- Create a suggestion and accept it 6- Add a new order to a basket 6-1- Go to Acquisitions and find a vendor 6-2- Create a new Basket 6-3- on the Basket click on 'Add to basket' and select 'From a suggestion' 6-4- Add the order created on 5-2- to the basket 6-5- On the item form click on Add item 6-6- Select a Fund and save the order 7- In the orders table click on the record and check the item Barcode ---> the Barcode is in hexadecimal form 8- Cancel order and delete the catalog record 9- Apply the patch 10- Repeat step 6-4, 6-5, 6-6 11- Check the item Barcode ---> the Barcode is not in hexadecimal form 12- run prove t/db_dependent/Barcodes.t Created attachment 167776 [details] [review] Bug 37070: Incorrect barcode generation when adding orders to basket When the autoBarcode preference is set to « generated in the form 1, 2, 3 » and the maximum barcode is length 16 (ex 1000000000000000), when adding orders to the basket,the numbers generated are in the hexadecimal form. to reproduce: 1- Set the system preference autoBarcode to « generated in the form 1, 2, 3 » 2- Search for a biblio record 3- In the record details, click on New -> New item 4- fill the Barcode field to a number with length 16 (1000000000000000) and add the item 5- Create a suggestion 5-1- Go to Acquisitions and click on suggestions 5-2- Create a suggestion and accept it 6- Add a new order to a basket 6-1- Go to Acquisitions and find a vendor 6-2- Create a new Basket 6-3- on the Basket click on 'Add to basket' and select 'From a suggestion' 6-4- Add the order created on 5-2- to the basket 6-5- On the item form click on Add item 6-6- Select a Fund and save the order 7- In the orders table click on the record and check the item Barcode ---> the Barcode is in hexadecimal form 8- Cancel order and delete the catalog record 9- Apply the patch 10- Repeat step 6-4, 6-5, 6-6 11- Check the item Barcode ---> the Barcode is not in hexadecimal form 12- run prove t/db_dependent/Barcodes.t Signed-off-by: David Nind <david@davidnind.com> Created attachment 172423 [details] [review] Bug 37070: Incorrect barcode generation when adding orders to basket When the autoBarcode preference is set to « generated in the form 1, 2, 3 » and the maximum barcode is length 16 (ex 1000000000000000), when adding orders to the basket,the numbers generated are in the hexadecimal form. to reproduce: 1- Set the system preference autoBarcode to « generated in the form 1, 2, 3 » 2- Search for a biblio record 3- In the record details, click on New -> New item 4- fill the Barcode field to a number with length 16 (1000000000000000) and add the item 5- Create a suggestion 5-1- Go to Acquisitions and click on suggestions 5-2- Create a suggestion and accept it 6- Add a new order to a basket 6-1- Go to Acquisitions and find a vendor 6-2- Create a new Basket 6-3- on the Basket click on 'Add to basket' and select 'From a suggestion' 6-4- Add the order created on 5-2- to the basket 6-5- On the item form click on Add item 6-6- Select a Fund and save the order 7- In the orders table click on the record and check the item Barcode ---> the Barcode is in hexadecimal form 8- Cancel order and delete the catalog record 9- Apply the patch 10- Repeat step 6-4, 6-5, 6-6 11- Check the item Barcode ---> the Barcode is not in hexadecimal form 12- run prove t/db_dependent/Barcodes.t Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> bsoletes: 167776 - Bug 37070: Incorrect barcode generation when adding orders to basket Created attachment 172424 [details] [review] Bug 37070: (QA follow-up) Fix qa script issues Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Always love some unit tests :) I wonder if this would not also affect the other spots a barcode is calculated? So we could change this to cataloguing and remove the "to basket". Pushed for 24.11! Well done everyone, thank you! Backported to 24.05.x for upcoming 24.05.06 I prefer not backport to 23.11.x in case of side-effects |