Summary: | Add another customizable region to the OPAC: right sidebar | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | koha.sekjal, kyle.m.hall, martin.renvoize, nengard, paul.poulain |
Version: | 3.10 | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Diagram of the proposed change
Bug 3708 - Add another customizable region to the OPAC: right sidebar Bug 3708 - Add another customizable region to the OPAC: right sidebar Signoff Patch Bug 3708 - Add another customizable region to the OPAC: right sidebar nav [SIGNED-OFF] Bug 3708 - Add another customizable region to the OPAC: right sidebar nav |
Description
Chris Cormack
2010-05-21 01:14:02 UTC
Created attachment 9841 [details] [review] Bug 3708 - Add another customizable region to the OPAC: right sidebar This patch creates a new system preference, OpacRightSidebar, in which the librarian can add HTML which will appear on the OPAC main page under the login form. If the user is logged in the content will appear in place of the login form. Thought I'de use this patch to also test the sandbox's over at biblibre (I used sandbox 9, which doesn't appear to have bug signing off yet) Comment's about the actual patch. Seems to work as expected once logged in, however when not logged in the div appear next to, as opposed to underneath the login box as suggested by the diagram. Looks like a minor css change is required. Created attachment 9883 [details] [review] Bug 3708 - Add another customizable region to the OPAC: right sidebar This patch creates a new system preference, OpacRightSidebar, in which the librarian can add HTML which will appear on the OPAC main page under the login form. If the user is logged in the content will appear in place of the login form. Tested again using the biblibre sandboxs.. All seems to work as expected now giving out good clean markup. Will try and grab a copy locally to sign-ff on properly. Created attachment 9994 [details] [review] Signoff Patch Martin, when you sign-off a patch, there's no need to assign the bug to you. The assignee of a bug is/should be the patch writer. Thanks Paul, I'de just misread that checkbox in bugzilla.. oops. QA comment: We already have OpacNav and OpacNavBottom. for consistency, I would like to see this syspref called OpacNavRight, that would be more logical. I would be highly pleased if you could update your patch in this direction Created attachment 10233 [details] [review] Bug 3708 - Add another customizable region to the OPAC: right sidebar nav This patch creates a new system preference, OpacNavRight, in which the librarian can add HTML which will appear on the OPAC main page under the login form. If the user is logged in the content will appear in place of the login form. Created attachment 10236 [details] [review] [SIGNED-OFF] Bug 3708 - Add another customizable region to the OPAC: right sidebar nav This patch creates a new system preference, OpacNavRight, in which the librarian can add HTML which will appear on the OPAC main page under the login form. If the user is logged in the content will appear in place of the login form. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Adds a new system preference (OpacNavRight) correctly, and shows it in the place in the diagram where expected. Strips out some YUI divs that may not be necessary... I differ to Owen on such user interface changes. Marking Passed QA. Path pushed, I really find the http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=1529 useful, i've sent a mail to nicole to suggest adding it to the documentation |