Bug 37106

Summary: Upgrade to 23.11.05.009 causes an error because Koha::installer::Output doesn't exist in 23.11.x
Product: Koha Reporter: Aleisha Amohia <aleisha>
Component: Installation and upgrade (command-line installer)Assignee: Aleisha Amohia <aleisha>
Status: RESOLVED FIXED QA Contact: Testopia <testopia>
Severity: blocker    
Priority: P5 - low CC: fridolin.somers, mtj, tomascohen
Version: 23.11   
Hardware: All   
OS: All   
Change sponsored?: Sponsored Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 36986, 26176    
Bug Blocks:    
Attachments: Bug 37106: Fix db revisions 231105009 and 231105010
Bug 37106: Fix db revisions 231105009 and 231105010
Bug 37106: Fix db revisions 231105009 and 231105010

Description Aleisha Amohia 2024-06-17 20:49:27 UTC
Upgrade to 23.11.05.009  [08:24:15]: 
ERROR - {UNKNOWN}: Can't use an undefined value as a subroutine reference at /usr/share/koha/lib/C4/Installer.pm line 739. at /usr/share/koha/lib/C4/Installer.pm line 741

This BREAKS installations of 23.11
Comment 1 Aleisha Amohia 2024-06-17 20:53:19 UTC
Created attachment 167810 [details] [review]
Bug 37106: Fix db revisions 231105009 and 231105010

They refer to Koha::Installer::Output methods which aren't available in 23.11.x

This reverts them to the standard `say $out` syntax.

Sponsored-by: Catalyst IT
Comment 2 Mason James 2024-06-18 01:29:23 UTC
Created attachment 167814 [details] [review]
Bug 37106: Fix db revisions 231105009 and 231105010

They refer to Koha::Installer::Output methods which aren't available in 23.11.x

This reverts them to the standard `say $out` syntax.

Sponsored-by: Catalyst IT
Comment 3 Mason James 2024-06-18 01:33:42 UTC
Created attachment 167815 [details] [review]
Bug 37106: Fix db revisions 231105009 and 231105010

They refer to Koha::Installer::Output methods which aren't available in 23.11.x

This reverts them to the standard `say $out` syntax.

Sponsored-by: Catalyst IT
Signed-off-by: Mason James <mtj@kohaaloha.com>
Comment 4 Mason James 2024-06-18 01:35:54 UTC
tested, looks good to me!
Comment 5 Fridolin Somers 2024-06-18 10:27:58 UTC
Ahhh thanks a lot.
It is a backport issue so I apply directly on 23.11.x
Comment 6 Fridolin Somers 2024-06-18 10:31:03 UTC
I should have tested upgrade from 23.11.05 to 23.11.06
I'll remember it
Comment 7 Fridolin Somers 2024-06-18 10:33:16 UTC
I'll ask to update packages with v23.11.06-1