| Summary: | Provide link to patron account when checking out to statistical patron ends checkout | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Catrina Berka <catrina> |
| Component: | Circulation | Assignee: | Eric Garcia <cubingguy714> |
| Status: | RESOLVED FIXED | QA Contact: | Emily Lamancusa (emlam) <emily.lamancusa> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | david, emily.lamancusa, gmcharlt, kyle.m.hall, lucas |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This enhancement links the patron details in the message displayed when checking out an item to a statistical patron, where that item is already checked out to another patron. Previously, the patron details in the message did not link to the patron. This now makes it easier for staff to check the patron's details, for example, to check for any incorrect charges.
|
Version(s) released in: |
24.11.00
|
| Circulation function: | |||
| Attachments: |
CardNumber should be link to patron account
Bug 37126: Added link to patron account when checking out to statistical patron ends checkout Bug 37126: Add link to patron account when checking out to statistical patron ends checkout Bug 37126: Add link to patron account when checking out to statistical patron ends checkout |
||
|
Description
Catrina Berka
2024-06-18 22:52:18 UTC
Created attachment 168331 [details] [review] Bug 37126: Added link to patron account when checking out to statistical patron ends checkout To test: 1. Check out item with patron 2. Check out the same item locally with a separate patron 3. Notice how "Item checked in from: PATRON_NAME (BORROWERNUMBER) is not hyperlinked 4. Apply patch 5. Repeat steps 1 and 2 6. Notice how "Item checked in from: PATRON_NAME (BORROWERNUMBER) is now hyperlinked to the borrower's details Created attachment 168336 [details] [review] Bug 37126: Add link to patron account when checking out to statistical patron ends checkout When checking out an item to a statistical patron, where that item is already checked out to another patron, the patron details in the message do not link to that patron. This patch fixes this so that the patron details are now linked. This could be useful so that staff can more easily access the patron's details, and can, for example, check for any incorrect charges. Test plan: 1. Set up a statistical patron for local use:[1] 1.1 Add a statistical patron category (Administration > Patrons and circulation > Patron categories), for example: - Category code: STAT - Description: Statistical - Enrollment period: 99 - Category type: Statistical 1.2 Add a new statistical paton (Patrons > +New patron > Statistical), for example: - Surname: Reference Statistical Patron - Card number: refstat 2. Check out an item to a standard patron. 3. Check out the same item to the statistical patron created in step 1.2. 4. Note that when the item is checked out to the statistical patron, the patron name and number in the message are not linked: "Item checked in from: PATRON_NAME (BORROWERNUMBER)". 5. Apply the patch. 6. Repeat steps 2 and 3. 7. Note that the patron details in the message are now linked. [1] Monday Minutes: Statistical Patron and Local Use: https://bywatersolutions.com/education/monday-minutes-statistical-patron-and-local-use Signed-off-by: David Nind <david@davidnind.com> Comment on attachment 168331 [details] [review] Bug 37126: Added link to patron account when checking out to statistical patron ends checkout I have fixed that patch so that it now works as expected - I changed patron=BOrrOWER to patron=BORROWER. With the patch as it was, there was no patron name and card number displayed. I also amended the commit message to follow the commit message guidelines (https://wiki.koha-community.org/wiki/Commit_messages). For some reason, the patch as applied did not have the test plan. I've added the assignee, and a release note. Feel free to amend these, and the patch commit message, as requried. Created attachment 168371 [details] [review] Bug 37126: Add link to patron account when checking out to statistical patron ends checkout When checking out an item to a statistical patron, where that item is already checked out to another patron, the patron details in the message do not link to that patron. This patch fixes this so that the patron details are now linked. This could be useful so that staff can more easily access the patron's details, and can, for example, check for any incorrect charges. Test plan: 1. Set up a statistical patron for local use:[1] 1.1 Add a statistical patron category (Administration > Patrons and circulation > Patron categories), for example: - Category code: STAT - Description: Statistical - Enrollment period: 99 - Category type: Statistical 1.2 Add a new statistical paton (Patrons > +New patron > Statistical), for example: - Surname: Reference Statistical Patron - Card number: refstat 2. Check out an item to a standard patron. 3. Check out the same item to the statistical patron created in step 1.2. 4. Note that when the item is checked out to the statistical patron, the patron name and number in the message are not linked: "Item checked in from: PATRON_NAME (BORROWERNUMBER)". 5. Apply the patch. 6. Repeat steps 2 and 3. 7. Note that the patron details in the message are now linked. [1] Monday Minutes: Statistical Patron and Local Use: https://bywatersolutions.com/education/monday-minutes-statistical-patron-and-local-use Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Works, code looks good, and QA tool passes. Thanks all! Passing QA Pushed for 24.11! Well done everyone, thank you! |