Summary: | Can't delete single title from a list using the "Remove from list" link | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
Status: | RESOLVED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | caroline.cyr-la-rose, cubingguy714, fridolin.somers, lucas, martin.renvoize, phil |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
24.11.00,24.05.05
|
Circulation function: | |
Bug Depends on: | 34478 | ||
Bug Blocks: | 36557, 38251 | ||
Attachments: |
Bug 37150: Can't delete single title from a list using the "Remove from list" link
Bug 37150: Can't delete single title from a list using the "Remove from list" link Bug 37150: Can't delete single title from a list using the "Remove from list" link Bug 37150: Can't delete single title from a list using the "Remove from list" link |
Description
Owen Leonard
2024-06-21 13:16:08 UTC
Created attachment 167965 [details] [review] Bug 37150: Can't delete single title from a list using the "Remove from list" link In the OPAC display of titles on a list, the "Remove from list" control needs to trigger a POST operation instead of GET. This patch achieves this by using the existing form, automatically checking the checkbox corresponding to the "Remove" link which has been clicked. To test, apply the patch and create a list if necessary, adding multiple titles to it. - View the contents of your list. - Each title on your list should have a "Remove from this list" link. - Click one of these. You should see a modal confirmation, "Are you sure you want to remove this item from the list?" - Confirming should delete the title form the list. - Cancelling should close the modal and uncheck the title's checkbox * I include automatic un-checking of the checkbox because the user didn't "deliberately" check the box, and I want to avoid having that title included with "deliberately" checked items. - Check multiple checkboxes in the list of titles and click "Remove from list" at the top of the list. - You should see a modal confirmation, "Are you sure you want to remove these items from the list?" - Confirming should result in all checked titles being removed from the list. - Cancelling should hide the modal, and your checked checkboxes should remain the same. Sponsored-by: Athens County Public Libraries I selected the checkboxes for two of the titles on my list that I wanted to place on hold, then I noticed a third one that I had already read, which I wanted to get rid of, so I used the Remove from this list for that item, got a modal asking if I wanted to remove that one title, said I did, and it and the two I wanted to place on hold were all three removed from the list. Created attachment 168015 [details] [review] Bug 37150: Can't delete single title from a list using the "Remove from list" link In the OPAC display of titles on a list, the "Remove from list" control needs to trigger a POST operation instead of GET. This patch appends a form for handling single entry deletions, populating the hidden input upon confirmation. To test, apply the patch and create a list if necessary, adding multiple titles to it. - View the contents of your list. - Each title on your list should have a "Remove from this list" link. - Click one of these. You should see a modal confirmation, "Are you sure you want to remove this item from the list?" - Confirming should delete the title form the list. - Check multiple checkboxes in the list of titles and click "Remove from list" at the top of the list. - You should see a modal confirmation, "Are you sure you want to remove these items from the list?" - Confirming should result in all checked titles being removed from the list. - Check one or more checkboxes and then click a single "Remove from list" link. After confirming, you should find that only the one title was removed from the list. Sponsored-by: Athens County Public Libraries Created attachment 168022 [details] [review] Bug 37150: Can't delete single title from a list using the "Remove from list" link In the OPAC display of titles on a list, the "Remove from list" control needs to trigger a POST operation instead of GET. This patch appends a form for handling single entry deletions, populating the hidden input upon confirmation. To test, apply the patch and create a list if necessary, adding multiple titles to it. - View the contents of your list. - Each title on your list should have a "Remove from this list" link. - Click one of these. You should see a modal confirmation, "Are you sure you want to remove this item from the list?" - Confirming should delete the title form the list. - Check multiple checkboxes in the list of titles and click "Remove from list" at the top of the list. - You should see a modal confirmation, "Are you sure you want to remove these items from the list?" - Confirming should result in all checked titles being removed from the list. - Check one or more checkboxes and then click a single "Remove from list" link. After confirming, you should find that only the one title was removed from the list. Sponsored-by: Athens County Public Libraries Signed-off-by: Eric Garcia <cubingguy714@gmail.com> Created attachment 168240 [details] [review] Bug 37150: Can't delete single title from a list using the "Remove from list" link In the OPAC display of titles on a list, the "Remove from list" control needs to trigger a POST operation instead of GET. This patch appends a form for handling single entry deletions, populating the hidden input upon confirmation. To test, apply the patch and create a list if necessary, adding multiple titles to it. - View the contents of your list. - Each title on your list should have a "Remove from this list" link. - Click one of these. You should see a modal confirmation, "Are you sure you want to remove this item from the list?" - Confirming should delete the title form the list. - Check multiple checkboxes in the list of titles and click "Remove from list" at the top of the list. - You should see a modal confirmation, "Are you sure you want to remove these items from the list?" - Confirming should result in all checked titles being removed from the list. - Check one or more checkboxes and then click a single "Remove from list" link. After confirming, you should find that only the one title was removed from the list. Sponsored-by: Athens County Public Libraries Signed-off-by: Eric Garcia <cubingguy714@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Thanks Owen, all working well no QA failures. Passing QA Pushed for 24.11! Well done everyone, thank you! Backported to 24.05.x for upcoming 24.05.05 Internal architecture, nothing to add/edit in the manual. |