| Summary: | Remove dead confirmation code when deleting tags from authority frameworks | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Phil Ringnalda <phil> |
| Component: | Templates | Assignee: | Phil Ringnalda <phil> |
| Status: | RESOLVED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | david, fridolin.somers, lucas, wainuiwitikapark |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37163 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37161 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37152 |
||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This removes redundant code that is no longer used when deleting authority tags. A previous change removed the extra page displayed after confirming the deletion an authority tag - this required you to click OK, and then you were returned to the list of tags.
|
Version(s) released in: |
24.11.00,24.05.02,23.11.07
|
| Circulation function: | |||
| Attachments: |
Bug 37162: Remove the [% IF ( delete_confirmed ) %] stuff in auth_tag_structure.tt
Bug 37162: Remove the [% IF ( delete_confirmed ) %] stuff in auth_tag_structure.tt Bug 37162: Remove the [% IF ( delete_confirmed ) %] stuff in auth_tag_structure.tt |
||
|
Description
Phil Ringnalda
2024-06-21 23:36:12 UTC
Created attachment 168005 [details] [review] Bug 37162: Remove the [% IF ( delete_confirmed ) %] stuff in auth_tag_structure.tt Since auth_tag_structure.pl redirects after deleting when the op is delete_confirmed (which is actually cud-delete_confirmed) rather than loading the template, there's no reason to have dead code for IF ( delete_confirmed ) which is both never set, and is never called when anything like it is set. Test plan: 1. With the patch applied, Administration - Authority types - Chronological Term row - Actions menu - MARC Structure 2. You've already verified that auth_tag_structure.tt isn't malformed, but for extra fun choose a tag, Actions menu - Delete - Yes, delete and verify that it was deleted Wups, doesn't block bug 36192, unlike marctagstructure this has been dead code since 2009. Created attachment 168034 [details] [review] Bug 37162: Remove the [% IF ( delete_confirmed ) %] stuff in auth_tag_structure.tt Since auth_tag_structure.pl redirects after deleting when the op is delete_confirmed (which is actually cud-delete_confirmed) rather than loading the template, there's no reason to have dead code for IF ( delete_confirmed ) which is both never set, and is never called when anything like it is set. Test plan: 1. With the patch applied, Administration - Authority types - Chronological Term row - Actions menu - MARC Structure 2. You've already verified that auth_tag_structure.tt isn't malformed, but for extra fun choose a tag, Actions menu - Delete - Yes, delete and verify that it was deleted Signed-off-by: Sam Lau <samalau@gmail.com> Created attachment 168109 [details] [review] Bug 37162: Remove the [% IF ( delete_confirmed ) %] stuff in auth_tag_structure.tt Since auth_tag_structure.pl redirects after deleting when the op is delete_confirmed (which is actually cud-delete_confirmed) rather than loading the template, there's no reason to have dead code for IF ( delete_confirmed ) which is both never set, and is never called when anything like it is set. Test plan: 1. With the patch applied, Administration - Authority types - Chronological Term row - Actions menu - MARC Structure 2. You've already verified that auth_tag_structure.tt isn't malformed, but for extra fun choose a tag, Actions menu - Delete - Yes, delete and verify that it was deleted Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed for 24.11! Well done everyone, thank you! Backported to 24.05.x for upcoming 24.05.02 Pushed to 23.11.x for 23.11.07 Not backporting to 23.05.x unless requested No real need, and nothing to document here. |