Summary: | Remove dead confirmation code when deleting tags from authority frameworks | ||
---|---|---|---|
Product: | Koha | Reporter: | Phil Ringnalda <phil> |
Component: | Templates | Assignee: | Phil Ringnalda <phil> |
Status: | Pushed to main --- | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | ||
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
24.11.00
|
|
Attachments: |
Bug 37162: Remove the [% IF ( delete_confirmed ) %] stuff in auth_tag_structure.tt
Bug 37162: Remove the [% IF ( delete_confirmed ) %] stuff in auth_tag_structure.tt Bug 37162: Remove the [% IF ( delete_confirmed ) %] stuff in auth_tag_structure.tt |
Description
Phil Ringnalda
2024-06-21 23:36:12 UTC
Created attachment 168005 [details] [review] Bug 37162: Remove the [% IF ( delete_confirmed ) %] stuff in auth_tag_structure.tt Since auth_tag_structure.pl redirects after deleting when the op is delete_confirmed (which is actually cud-delete_confirmed) rather than loading the template, there's no reason to have dead code for IF ( delete_confirmed ) which is both never set, and is never called when anything like it is set. Test plan: 1. With the patch applied, Administration - Authority types - Chronological Term row - Actions menu - MARC Structure 2. You've already verified that auth_tag_structure.tt isn't malformed, but for extra fun choose a tag, Actions menu - Delete - Yes, delete and verify that it was deleted Wups, doesn't block bug 36192, unlike marctagstructure this has been dead code since 2009. Created attachment 168034 [details] [review] Bug 37162: Remove the [% IF ( delete_confirmed ) %] stuff in auth_tag_structure.tt Since auth_tag_structure.pl redirects after deleting when the op is delete_confirmed (which is actually cud-delete_confirmed) rather than loading the template, there's no reason to have dead code for IF ( delete_confirmed ) which is both never set, and is never called when anything like it is set. Test plan: 1. With the patch applied, Administration - Authority types - Chronological Term row - Actions menu - MARC Structure 2. You've already verified that auth_tag_structure.tt isn't malformed, but for extra fun choose a tag, Actions menu - Delete - Yes, delete and verify that it was deleted Signed-off-by: Sam Lau <samalau@gmail.com> Created attachment 168109 [details] [review] Bug 37162: Remove the [% IF ( delete_confirmed ) %] stuff in auth_tag_structure.tt Since auth_tag_structure.pl redirects after deleting when the op is delete_confirmed (which is actually cud-delete_confirmed) rather than loading the template, there's no reason to have dead code for IF ( delete_confirmed ) which is both never set, and is never called when anything like it is set. Test plan: 1. With the patch applied, Administration - Authority types - Chronological Term row - Actions menu - MARC Structure 2. You've already verified that auth_tag_structure.tt isn't malformed, but for extra fun choose a tag, Actions menu - Delete - Yes, delete and verify that it was deleted Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed for 24.11! Well done everyone, thank you! |