Summary: | Can't edit frequencies due to stray cud- in modify op | ||
---|---|---|---|
Product: | Koha | Reporter: | Phil Ringnalda <phil> |
Component: | Serials | Assignee: | Phil Ringnalda <phil> |
Status: | RESOLVED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | blawlor, david, fridolin.somers, lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This fixes the serials frequency edit form so that they can be edited (Serials > Manage frequencies > select edit action for a frequency). Before this, you couldn't edit the frequency - the form was empty. (This is related to the CSRF changes added in Koha 24.05 to improve form security.)
|
Version(s) released in: |
24.11.00,24.05.02
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 36192 | ||
Attachments: |
Bug 37165: Can't edit frequencies due to stray cud- in modify op
Bug 37165: Can't edit frequencies due to stray cud- in modify op Bug 37165: Can't edit frequencies due to stray cud- in modify op |
Description
Phil Ringnalda
2024-06-22 23:38:52 UTC
Created attachment 168006 [details] [review] Bug 37165: Can't edit frequencies due to stray cud- in modify op The op modify in subscription-frequencies.pl isn't a cud- operation, it's a GET of the editing form, so it shouldn't have been changed to cud-modify. Test plan: 1. Don't apply the patch yet 2. Serials - Manage frequencies - for any frequency click Edit 2. Note that the editing form is empty 3. Apply patch, restart_all 4. Repeat step 2, note that now the editing form has the existing data 5. Change anything, Display order is nice, and save to verify that cud-savemod still works Created attachment 168026 [details] [review] Bug 37165: Can't edit frequencies due to stray cud- in modify op The op modify in subscription-frequencies.pl isn't a cud- operation, it's a GET of the editing form, so it shouldn't have been changed to cud-modify. Test plan: 1. Don't apply the patch yet 2. Serials - Manage frequencies - for any frequency click Edit 2. Note that the editing form is empty 3. Apply patch, restart_all 4. Repeat step 2, note that now the editing form has the existing data 5. Change anything, Display order is nice, and save to verify that cud-savemod still works Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Created attachment 168111 [details] [review] Bug 37165: Can't edit frequencies due to stray cud- in modify op The op modify in subscription-frequencies.pl isn't a cud- operation, it's a GET of the editing form, so it shouldn't have been changed to cud-modify. Test plan: 1. Don't apply the patch yet 2. Serials - Manage frequencies - for any frequency click Edit 2. Note that the editing form is empty 3. Apply patch, restart_all 4. Repeat step 2, note that now the editing form has the existing data 5. Change anything, Display order is nice, and save to verify that cud-savemod still works Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed for 24.11! Well done everyone, thank you! Backported to 24.05.x for upcoming 24.05.02 Full CSRF not in 23.11.x Nothing to document, just fixed a bug. |