Bug 37165

Summary: Can't edit frequencies due to stray cud- in modify op
Product: Koha Reporter: Phil Ringnalda <phil>
Component: SerialsAssignee: Phil Ringnalda <phil>
Status: Pushed to main --- QA Contact: Testopia <testopia>
Severity: major    
Priority: P5 - low CC: blawlor
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00
Bug Depends on:    
Bug Blocks: 36192    
Attachments: Bug 37165: Can't edit frequencies due to stray cud- in modify op
Bug 37165: Can't edit frequencies due to stray cud- in modify op
Bug 37165: Can't edit frequencies due to stray cud- in modify op

Description Phil Ringnalda 2024-06-22 23:38:52 UTC
serials/subscription-frequencies.pl has two modify ops: a POST with cud-savemod changes the frequency, and a GET with modify loads the editing form, except that was changed to cud-modify when it shouldn't have been.
Comment 1 Phil Ringnalda 2024-06-22 23:47:36 UTC
Created attachment 168006 [details] [review]
Bug 37165: Can't edit frequencies due to stray cud- in modify op

The op modify in subscription-frequencies.pl isn't a cud- operation, it's
a GET of the editing form, so it shouldn't have been changed to cud-modify.

Test plan:
1. Don't apply the patch yet
2. Serials - Manage frequencies - for any frequency click Edit
2. Note that the editing form is empty
3. Apply patch, restart_all
4. Repeat step 2, note that now the editing form has the existing data
5. Change anything, Display order is nice, and save to verify that
   cud-savemod still works
Comment 2 Brendan Lawlor 2024-06-24 16:05:57 UTC
Created attachment 168026 [details] [review]
Bug 37165: Can't edit frequencies due to stray cud- in modify op

The op modify in subscription-frequencies.pl isn't a cud- operation, it's
a GET of the editing form, so it shouldn't have been changed to cud-modify.

Test plan:
1. Don't apply the patch yet
2. Serials - Manage frequencies - for any frequency click Edit
2. Note that the editing form is empty
3. Apply patch, restart_all
4. Repeat step 2, note that now the editing form has the existing data
5. Change anything, Display order is nice, and save to verify that
   cud-savemod still works

Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Comment 3 Nick Clemens (kidclamp) 2024-06-25 22:50:50 UTC
Created attachment 168111 [details] [review]
Bug 37165: Can't edit frequencies due to stray cud- in modify op

The op modify in subscription-frequencies.pl isn't a cud- operation, it's
a GET of the editing form, so it shouldn't have been changed to cud-modify.

Test plan:
1. Don't apply the patch yet
2. Serials - Manage frequencies - for any frequency click Edit
2. Note that the editing form is empty
3. Apply patch, restart_all
4. Repeat step 2, note that now the editing form has the existing data
5. Change anything, Display order is nice, and save to verify that
   cud-savemod still works

Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 4 Katrin Fischer 2024-06-27 09:53:09 UTC
Pushed for 24.11!

Well done everyone, thank you!