Summary: | Use staffClientBaseURL and OPACBaseURL to rewrite URLs in Koha | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | System Administration | Assignee: | Bugs List <koha-bugs> |
Status: | REOPENED --- | QA Contact: | Bugs List <koha-bugs> |
Severity: | minor | ||
Priority: | P5 - low | CC: | J.P.Knight, katrin.fischer, Sebastien.Hinderer, tomascohen |
Version: | Main | ||
Hardware: | PC | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
Description
Chris Cormack
2010-05-21 01:14:10 UTC
still relevant, the staff syspref is used nowhere A quick search shows that staffClientBaseURL is currently at least used by 2 scripts: misc/load_testing/benchmark_circulation.pl opac/opac-userupdate.pl I am not sure if it should be used in other places too, but I think this bug can be closed until someone reports a problem with these system preferences. I received an email from Sebastien Hinderer explaining why this bug should remain open. Copying his explanation into this bug with his permission: The thing is, as long as this system preference is not implemented, you have to have a virtualhost for koha. I mean, the URLs for Koha will have to start by / So for instance you could not have an URL such as www.mylibrary.com/koha/.../script.pl which was a problem for the library I was working for. I think the title of this bug is not quite right, but not sure to rephrase it better. Now that we've had things like Bug 16401 push to master which is most definitely using staffClientBaseURL (and indeed including the protocol details now) it looks like we're actively using staffClientBaseURL alot more. Its in svc/import_bib, the CAS authentication, several test suites, and (if it gets unblocked) bug 12027 will use it for Shibboleth too. I guess the question at this point is where else in the Koha codebase does staffClientBaseURL need to appear? Having a look at some pages returned by the staff client at the moment we have a lot of "path-absolute" (in RFC 3986 terms) URIs in there. For example "/intranet-tmpl/prog/css/mainpage.css", "/cgi-bin/koha/catalogue/search.pl", "/intranet-tmpl/prog/js/basket.js". Those look to be hard coded in the templates (eg koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt), so to change them will mean a large number of templates will need to be altered. One option might be to drop the leading slash on the path in these URLs the templates and include a BASE element in the head of the HTML output that specified the staffClientBaseURL? That would mean that people could put the Koha staff client under any base path they liked then (which I think is the major thrust of this bug report?). Opinions? |