Bug 37174

Created attachment 168039 [details]
Data before (which fails) and after (which works) assigning branchcode to all records

After upgrading from 23.11 to 24.05, renewals failed to work correctly using Circulation > Renew, the Renew option on the menu bar, or the Patron’s checkout summary.  For example, the patron’s checkout summary reported all items as "Not Renewable (0 of 0 renewals remaining)" while the circulation rule for this patron category allows 3.  

I found an earlier bug issue from 2017 (Koha 16.11.04) in which deleting and recreating all categories resolved this issue (https://koha.katipo.co.narkive.com/PWWM7AWH/all-items-not-renewable). I created a new category, assigned a user to this category, and checked the Patron screen. For this single user, renewals returned to working properly.

To avoid the work this solution would require, I checked the contents of table "circulation_rules". I found that branchcode was set to our correct code ("FCC") for the new entry, but was NULL for many of the properties in existing categories, including the patron category having the problem. I assigned the correct value to all entries using "UPDATE circulation_rules SET branchcode = 'FCC' WHERE branchcode IS NULL;" and the patron summary properly reported "(x of 3 renewals)" and allowed renewals. Checking a data backup from 2023, the NULL values existed in 23.11, so this data pre-existed the upgrade to 24.05 but the renewals operated correctly with this data in the earlier version. 

A backup of the circulation_rules table data before and after the change are attached. This was the only table modified to correct the symptom.