Summary: | Column "comments" in ILL requests table gives error on sorting, paging cannot be changed | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | ILL | Assignee: | Pedro Amorim <pedro.amorim> |
Status: | RESOLVED FIXED | QA Contact: | Paul Derscheid <paul.derscheid> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, jesse, lucas, magnus, nick, paul.derscheid, pedro.amorim, phil, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
24.11.00,24.05.06,23.11.11
|
|
Circulation function: | |||
Bug Depends on: | 36904 | ||
Bug Blocks: | |||
Attachments: |
Bug 37178: Disable sorting on comments column
Bug 37178: Disable sorting on comments column Bug 37178: Disable sorting on comments column |
Description
Katrin Fischer
2024-06-25 08:10:38 UTC
Created attachment 168311 [details] [review] Bug 37178: Disable sorting on comments column The 'easy' fix here is to disable sorting on the column as that is a count processed value and not a value directly present on the ILL request table row. It may be easier than I think to implement sorting on that column but I don't have the time to invest in it at this point, happy to look at others suggestions here. I think the other error you mention about the records per page is a non-issue as I believe it only occurs once you've sorted by comments first, i.e. if you refresh the page and change the records per page it works fine. I think deactivating sorting for that column would be fine for now if it makes the unfriendly errors go away. We can still revisit later. Created attachment 172242 [details] [review] Bug 37178: Disable sorting on comments column Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Adding others here as it's a very trivial fix needing PQA. Created attachment 174407 [details] [review] Bug 37178: Disable sorting on comments column Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Pushed for 24.11! Well done everyone, thank you! Also a problem in 23.11.10. Backported to 24.05.x for upcoming 24.05.06 Pushed to 23.11.x for 23.11.11 Not pushed to LTS. Marked Resolved. If you feel this should be in LTS please reply with your reason. (In reply to Jesse Maseto from comment #11) > Not pushed to LTS. Marked Resolved. > > If you feel this should be in LTS please reply with your reason. This should be considered for backport as it's working around a nasty JS error by disabling functionality that was unintentionally enabled. |