Bug 37186

Summary: Cannot delete a rotating collection
Product: Koha Reporter: Eric Garcia <cubingguy714>
Component: ToolsAssignee: Eric Garcia <cubingguy714>
Status: Needs documenting --- QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: fridolin.somers, lucas, phil
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00,24.05.04
Circulation function:
Attachments: Bug 37186: Fixed deletion of rotating collections
Bug 37186: Fixed deletion of rotating collections
Bug 37186: Fixed deletion of rotating collections

Description Eric Garcia 2024-06-25 19:54:47 UTC
To recreate:

1. Tools -> Rotating collections
2. Create a rotating collection
3. From rotating collections Action -> Delete
4. Collection is not deleted
Comment 1 Lucas Gass (lukeg) 2024-06-25 21:43:18 UTC
To make this form work as a link we need the fix from Bug 37190.
Comment 2 Owen Leonard 2024-06-26 15:19:40 UTC
(In reply to Lucas Gass from comment #1)
> To make this form work as a link we need the fix from Bug 37190.

This form has already been revised to convert it to a POSTed operation, but the submit button wasn't converted from an <a>. If we replace the "confirmdelete" link with a button it will work:

<button type="submit" class="btn btn-default confirmdelete"><i class="fa fa-trash-can"></i> Delete</button>
Comment 3 Lucas Gass (lukeg) 2024-06-26 15:28:18 UTC
(In reply to Owen Leonard from comment #2)
> (In reply to Lucas Gass from comment #1)
> > To make this form work as a link we need the fix from Bug 37190.
> 
> This form has already been revised to convert it to a POSTed operation, but
> the submit button wasn't converted from an <a>. If we replace the
> "confirmdelete" link with a button it will work:
> 
> <button type="submit" class="btn btn-default confirmdelete"><i class="fa
> fa-trash-can"></i> Delete</button>

Do you think that would be better than adopting Nick's new for as a link? Bug 36246
Comment 4 Owen Leonard 2024-06-26 19:20:44 UTC
(In reply to Lucas Gass from comment #3)
> Do you think that would be better than adopting Nick's new for as a link?
> Bug 36246

I guess it doesn't really matter one way or the other. If you wanted to submit a fix which uses form-submit.js it would at least be a good way to test Bug 37190!
Comment 5 Eric Garcia 2024-07-08 17:14:43 UTC
Created attachment 168610 [details] [review]
Bug 37186: Fixed deletion of rotating collections

To test:
1. Tools -> Rotating collections
2. Create a rotating collection
3. In new collection Actions -> Delete
4. Notice collection is not deleted
5. Apply patch
6. In new collection Actions -> Delete
7. Notice collection is deleted
Comment 6 Roman Dolny 2024-07-08 18:10:39 UTC
Created attachment 168611 [details] [review]
Bug 37186: Fixed deletion of rotating collections

To test:
1. Tools -> Rotating collections
2. Create a rotating collection
3. In new collection Actions -> Delete
4. Notice collection is not deleted
5. Apply patch
6. In new collection Actions -> Delete
7. Notice collection is deleted

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Comment 7 Lucas Gass (lukeg) 2024-07-08 18:37:20 UTC
Created attachment 168612 [details] [review]
Bug 37186: Fixed deletion of rotating collections

To test:
1. Tools -> Rotating collections
2. Create a rotating collection
3. In new collection Actions -> Delete
4. Notice collection is not deleted
5. Apply patch
6. In new collection Actions -> Delete
7. Notice collection is deleted

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 8 Katrin Fischer 2024-07-09 12:56:47 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 9 Lucas Gass (lukeg) 2024-09-12 19:02:42 UTC
Backported to 24.05.x for upcoming 24.05.04
Comment 10 Fridolin Somers 2024-10-21 12:20:53 UTC
cud-delete not for 23.11.x