| Summary: | Cannot delete a rotating collection | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Eric Garcia <cubingguy714> |
| Component: | Tools | Assignee: | Eric Garcia <cubingguy714> |
| Status: | RESOLVED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | caroline.cyr-la-rose, fridolin.somers, lucas, phil |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
24.11.00,24.05.04
|
|
| Circulation function: | |||
| Attachments: |
Bug 37186: Fixed deletion of rotating collections
Bug 37186: Fixed deletion of rotating collections Bug 37186: Fixed deletion of rotating collections |
||
|
Description
Eric Garcia
2024-06-25 19:54:47 UTC
To make this form work as a link we need the fix from Bug 37190. (In reply to Lucas Gass from comment #1) > To make this form work as a link we need the fix from Bug 37190. This form has already been revised to convert it to a POSTed operation, but the submit button wasn't converted from an <a>. If we replace the "confirmdelete" link with a button it will work: <button type="submit" class="btn btn-default confirmdelete"><i class="fa fa-trash-can"></i> Delete</button> (In reply to Owen Leonard from comment #2) > (In reply to Lucas Gass from comment #1) > > To make this form work as a link we need the fix from Bug 37190. > > This form has already been revised to convert it to a POSTed operation, but > the submit button wasn't converted from an <a>. If we replace the > "confirmdelete" link with a button it will work: > > <button type="submit" class="btn btn-default confirmdelete"><i class="fa > fa-trash-can"></i> Delete</button> Do you think that would be better than adopting Nick's new for as a link? Bug 36246 (In reply to Lucas Gass from comment #3) > Do you think that would be better than adopting Nick's new for as a link? > Bug 36246 I guess it doesn't really matter one way or the other. If you wanted to submit a fix which uses form-submit.js it would at least be a good way to test Bug 37190! Created attachment 168610 [details] [review] Bug 37186: Fixed deletion of rotating collections To test: 1. Tools -> Rotating collections 2. Create a rotating collection 3. In new collection Actions -> Delete 4. Notice collection is not deleted 5. Apply patch 6. In new collection Actions -> Delete 7. Notice collection is deleted Created attachment 168611 [details] [review] Bug 37186: Fixed deletion of rotating collections To test: 1. Tools -> Rotating collections 2. Create a rotating collection 3. In new collection Actions -> Delete 4. Notice collection is not deleted 5. Apply patch 6. In new collection Actions -> Delete 7. Notice collection is deleted Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Created attachment 168612 [details] [review] Bug 37186: Fixed deletion of rotating collections To test: 1. Tools -> Rotating collections 2. Create a rotating collection 3. In new collection Actions -> Delete 4. Notice collection is not deleted 5. Apply patch 6. In new collection Actions -> Delete 7. Notice collection is deleted Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Pushed for 24.11! Well done everyone, thank you! Backported to 24.05.x for upcoming 24.05.04 cud-delete not for 23.11.x Bug fix, nothing to add/edit in the manual. |