Bug 37194

Summary:	Improve link from unconfigured ILL module
Product:	Koha	Reporter:	Magnus Enger <magnus>
Component:	ILL	Assignee:	Sam Lau <samalau>
Status:	Pushed to stable ---	QA Contact:
Severity:	minor
Priority:	P5 - low	CC:	lucas, pedro.amorim, samalau, tomascohen
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	24.11.00,24.05.06
Circulation function:
Attachments:	Bug 37194: Improve link from unconfigured ILL module Bug 37194: Improve link from unconfigured ILL module

Description Magnus Enger 2024-06-26 11:49:36 UTC

To reproduce in ktd:

- Enable the ILLModule syspref
- Go to the ILL module
- Observe the link that reads "Take a look at the about page" and points to http://localhost:8081/cgi-bin/koha/about.pl#sysinfo_panel
- The link takes you to the "About Koha" page, but it does not show the contents of the "System information" tab, where the relevant information is
- Clicking on the "System information" tab changes the page to http://localhost:8081/cgi-bin/koha/about.pl?tab=sysinfo

Suggestions: 
- Change the link text so it reads 'Take a look at "System information" on the "About Koha" page'
- Change the actual link from http://localhost:8081/cgi-bin/koha/about.pl#sysinfo_panel to http://localhost:8081/cgi-bin/koha/about.pl?tab=sysinfo

Comment 1 Sam Lau 2024-06-26 20:48:39 UTC

Created attachment 168181 [details] [review]
Bug 37194: Improve link from unconfigured ILL module

To test:
1) Enable the ILLModule syspref
2) Go to the ILL module
3) Observe the link that reads "Take a look at the about page" and points to http://localhost:8081/cgi-bin/koha/about.pl#sysinfo_panel
4) Apply patch
5) Observe the link that reads "Take a look at the about page" now points to http://localhost:8081/cgi-bin/koha/about.pl?tab=sysinfo

Comment 2 Pedro Amorim 2024-07-01 10:40:37 UTC

Created attachment 168312 [details] [review]
Bug 37194: Improve link from unconfigured ILL module

To test:
1) Enable the ILLModule syspref
2) Go to the ILL module
3) Observe the link that reads "Take a look at the about page" and points to http://localhost:8081/cgi-bin/koha/about.pl#sysinfo_panel
4) Apply patch
5) Observe the link that reads "Take a look at the about page" now points to http://localhost:8081/cgi-bin/koha/about.pl?tab=sysinfo

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>

Comment 3 Katrin Fischer 2024-07-09 12:52:19 UTC

Picked from QA queue for push to main.

Comment 4 Katrin Fischer 2024-07-09 12:56:50 UTC

Pushed for 24.11!

Well done everyone, thank you!

Comment 5 Lucas Gass (lukeg) 2024-11-18 17:53:39 UTC

Backported to 24.05.x for upcoming 24.05.06