| Summary: | Add table settings to itemsearch results | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Lucas Gass <lucas> |
| Component: | Searching | Assignee: | Lucas Gass <lucas> |
| Status: | Needs Signoff --- | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | oleonard |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Bug Depends on: | 37249 | ||
| Bug Blocks: | 13965 | ||
| Attachments: |
Bug 37238: Add column configuration to item search results table
Bug 37238: Add column configuration to item search results table Bug 37238: Replace jquery.dataTables.columnFilter.js with native DataTables function |
||
|
Description
Lucas Gass
2024-07-02 22:09:52 UTC
Created attachment 168409 [details] [review] Bug 37238: Add column configuration to item search results table To test: 1. APPLY PATCH 2. Do an item search that will return results. 3. To the right of the table notice thee Columns, Export, Configure buttons 4. Use the Columns button to hide and show various columns, make sure it works right. 5. Use the Export button to try and export the table in various file formats. You should only see visible columns in your export. 6. Go to Admin -> Table settings, make sure you can hide columns properly from there. Created attachment 168411 [details] [review] Bug 37238: Add column configuration to item search results table To test: 1. APPLY PATCH 2. Do an item search that will return results. 3. To the right of the table notice thee Columns, Export, Configure buttons 4. Use the Columns button to hide and show various columns, make sure it works right. 5. Use the Export button to try and export the table in various file formats. You should only see visible columns in your export. 6. Go to Admin -> Table settings, make sure you can hide columns properly from there. Signed-off-by: Sam Lau <samalau@gmail.com> *** Bug 23565 has been marked as a duplicate of this bug. *** I'm getting inconsistent behavior from the column header search fields. Sometimes they work, sometimes they incorrectly filter out all results, and sometimes I get a 500 error:
C4::Items::SearchItems(): DBI Exception: DBD::mysql::st execute failed: Column 'itemnumber' in where clause is ambiguous at /kohadevbox/koha/catalogue/itemsearch.pl line 252
at /usr/share/perl5/DBIx/Class/Exception.pm line 77
DBIx::Class::Exception::throw('DBIx::Class::Exception', 'DBI Exception: DBD::mysql::st execute failed: Column \'itemnumber\' in where clause is ambiguous', 0) called at /usr/share/perl5/DBIx/Class/Schema.pm line 1118
(In reply to Owen Leonard from comment #4) > I'm getting inconsistent behavior from the column header search fields. > Sometimes they work, sometimes they incorrectly filter out all results, and > sometimes I get a 500 error: > C4::Items::SearchItems(): DBI Exception: DBD::mysql::st execute failed: > Column 'itemnumber' in where clause is ambiguous at > /kohadevbox/koha/catalogue/itemsearch.pl line 252 > at /usr/share/perl5/DBIx/Class/Exception.pm line 77 > DBIx::Class::Exception::throw('DBIx::Class::Exception', 'DBI Exception: > DBD::mysql::st execute failed: Column \'itemnumber\' in where clause is > ambiguous', 0) called at /usr/share/perl5/DBIx/Class/Schema.pm line 1118 Thanks Owen. For the 500 error, I am reproducing that without my patch applied. It seems specific to the itemnumber column? It also seems like many of the columns, but not all, are incorrectly filtering without this patch applied. Created attachment 168483 [details] [review] Bug 37238: Replace jquery.dataTables.columnFilter.js with native DataTables function I fixed the 500 error when using itemnumber filtering on Bug 37249. The follow-up patch here make filtering work when columns are hidden. I did notice that when filtering things like Item type, Home library, currently library, damaged, lost, ect. it requires the user to know the code. The description doesn't work. This seems to be true with or without my patch. The same seems to true when filtering dates. You must use the ISO date or else filtering doesn't work. This is also true with or without this patchset. |