Bug 37249

Summary:	Item search column filtering broken
Product:	Koha	Reporter:	Lucas Gass (lukeg) <lucas>
Component:	Searching	Assignee:	Lucas Gass (lukeg) <lucas>
Status:	Pushed to main ---	QA Contact:	Matt Blenkinsop <matt.blenkinsop>
Severity:	normal
Priority:	P5 - low	CC:	emmi.takkinen, matt.blenkinsop, phil
Version:	Main
Hardware:	All
OS:	All
See Also:	https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37369
Change sponsored?:	---	Patch complexity:	---
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	24.11.00
Circulation function:
Bug Depends on:
Bug Blocks:	37238
Attachments:	Bug 37249: disambiguate itemnumber with USING clause Bug 37249: disambiguate itemnumber with USING clause Bug 37249: disambiguate itemnumber with USING clause

Description Lucas Gass (lukeg) 2024-07-03 17:10:22 UTC

To test:

1. Do an item search that returns results 
2. Use the column filtering available at the top of the table for each column 
3. Try itemnumber, get a 500 error each time 
4. As long as there is data in the itemnumber column and you attempt to use another column you'll see a 500 error.

Without anything in the itemnumber column:

5. Try filtering by home library, currently library, item type, or shevling location. 
6. The filtering doesn't work unless you type the code, not the description.

Comment 1 Lucas Gass (lukeg) 2024-07-03 20:41:24 UTC

Created attachment 168478 [details] [review]
Bug 37249: disambiguate itemnumber with USING clause

1. Do an item search that returns results
2. Use the column filtering available at the top of the table for each column
3. Try itemnumber, get a 500 error each time
4. As long as there is data in the itemnumber column and you attempt to use another column you'll see a 500 error.
5. APPLY PATCH, restart_all
6. The itemnumber column filtering should now work as expected

Comment 2 Phil Ringnalda 2024-07-04 01:56:04 UTC

Created attachment 168486 [details] [review]
Bug 37249: disambiguate itemnumber with USING clause

1. Do an item search that returns results
2. Use the column filtering available at the top of the table for each column
3. Try itemnumber, get a 500 error each time
4. As long as there is data in the itemnumber column and you attempt to use another column you'll see a 500 error.
5. APPLY PATCH, restart_all
6. The itemnumber column filtering should now work as expected

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>

Comment 3 Matt Blenkinsop 2024-07-04 15:09:50 UTC

Created attachment 168505 [details] [review]
Bug 37249: disambiguate itemnumber with USING clause

1. Do an item search that returns results
2. Use the column filtering available at the top of the table for each column
3. Try itemnumber, get a 500 error each time
4. As long as there is data in the itemnumber column and you attempt to use another column you'll see a 500 error.
5. APPLY PATCH, restart_all
6. The itemnumber column filtering should now work as expected

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>

Comment 4 Katrin Fischer 2024-07-05 12:53:31 UTC

Ok, help me :) This works, but I would have thought that with the table as prefix, they already should have been disambiguated. Can you explain?

Comment 5 Katrin Fischer 2024-07-05 13:50:35 UTC

Pushed for 24.11!

Well done everyone, thank you!