Bug 37254

Summary:	Dropdown values not cleared after pressing clear in circulation rules
Product:	Koha	Reporter:	Emmi Takkinen <emmi.takkinen>
Component:	Fines and fees	Assignee:	Emmi Takkinen <emmi.takkinen>
Status:	Pushed to oldstable ---	QA Contact:	Laura Escamilla <Laura.escamilla>
Severity:	minor
Priority:	P5 - low	CC:	fridolin.somers, Laura.escamilla, lucas, wainuiwitikapark
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	---
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	24.11.00,24.05.04,23.11.09
Circulation function:
Attachments:	Bug 37254: Fix clearing of dropdown values on circulation rules Bug 37254: Fix clearing of dropdown values on circulation rules Bug 37254: Fix clearing of dropdown values on circulation rules

Description Emmi Takkinen 2024-07-04 10:11:40 UTC

When one tries to clear the rule they are editing in circulation rules page via "Clear" button, dropdown selectors aren't populated with default value (first on the list).

To reproduce:
1. Select a rule to edit.
2. Press "Clear" button to return edit rows values back to default values.
=> Values in dropdowns aren't set back as default, instead they have same values as rule you edited before pressing "Clear".

Comment 1 Emmi Takkinen 2024-07-04 12:09:31 UTC

Created attachment 168502 [details] [review]
Bug 37254: Fix clearing of dropdown values on circulation rules

When one tries to clear the rule they are editing in circulation
rules page via "Clear" button, dropdown selectors aren't populated
with default value (first on the list).

To reproduce:
1. Select a rule to edit.
2. Press "Clear" button to return edit rows values back to default values.
=> Values in dropdowns aren't set back as default, instead they have
same values as rule you edited before pressing "Clear".
3. Apply this patch.
4. Select rule to edit, then press "Clear".
=> Dropdowns now have default values.

Sponsored-by: Koha-Suomi Oy

Comment 2 Chris Cormack 2024-07-04 22:12:28 UTC

Created attachment 168522 [details] [review]
Bug 37254: Fix clearing of dropdown values on circulation rules

When one tries to clear the rule they are editing in circulation
rules page via "Clear" button, dropdown selectors aren't populated
with default value (first on the list).

To reproduce:
1. Select a rule to edit.
2. Press "Clear" button to return edit rows values back to default values.
=> Values in dropdowns aren't set back as default, instead they have
same values as rule you edited before pressing "Clear".
3. Apply this patch.
4. Select rule to edit, then press "Clear".
=> Dropdowns now have default values.

Sponsored-by: Koha-Suomi Oy
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>

Comment 3 Laura Escamilla 2024-07-25 15:50:43 UTC

Created attachment 169582 [details] [review]
Bug 37254: Fix clearing of dropdown values on circulation rules

Looks great! QA tool is also happy. Passing QA

Comment 4 Katrin Fischer 2024-08-09 15:37:05 UTC

Pushed for 24.11!

Well done everyone, thank you!

Comment 5 Lucas Gass (lukeg) 2024-09-11 16:21:05 UTC

Backported to 24.05.x for upcoming 24.05.04

Comment 6 Fridolin Somers 2024-09-25 08:42:40 UTC

Pushed to 23.11.x for 23.11.09

Comment 7 Wainui Witika-Park 2024-09-27 02:25:24 UTC

Is this okay to be backported during string freeze?

Comment 8 Fridolin Somers 2024-09-27 07:32:42 UTC

(In reply to wainuiwitikapark from comment #7)
> Is this okay to be backported during string freeze?

Yes there are no translated string in changes

Comment 9 Wainui Witika-Park 2024-09-30 07:35:57 UTC

(In reply to Fridolin Somers from comment #8)
> (In reply to wainuiwitikapark from comment #7)
> > Is this okay to be backported during string freeze?
> 
> Yes there are no translated string in changes

Thanks Fridolin!

I think I might wait until next release to do this one :)