Bug 37271

Summary: Recall status should be 'requested' in overdue_recalls.pl
Product: Koha Reporter: Janusz Kaczmarek <januszop>
Component: CirculationAssignee: Janusz Kaczmarek <januszop>
Status: Pushed to stable --- QA Contact: Katrin Fischer <katrin.fischer>
Severity: trivial    
Priority: P5 - low CC: gmcharlt, kyle.m.hall, lucas, phil, tomascohen
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00,24.05.06
Circulation function: recalls
Bug Depends on: 19532    
Bug Blocks:    
Attachments: Bug 37271: Recall status should be 'requested' in overdue_recalls.pl
Bug 37271: Recall status should be 'requested' in overdue_recalls.pl

Description Janusz Kaczmarek 2024-07-08 09:33:54 UTC
In "Bug 19532: Make recalls.status an ENUM" one-letter statuses were replaced by their verbal equivalents.  But in overdue_recalls.pl remained "R".  As a result, recalls never overdue.
Comment 1 Janusz Kaczmarek 2024-07-08 09:38:01 UTC
Created attachment 168581 [details] [review]
Bug 37271: Recall status should be 'requested' in overdue_recalls.pl

In "Bug 19532: Make recalls.status an ENUM" one-letter statuses were
replaced by their verbal equivalents.  But in overdue_recalls.pl
remained "R".  As a result, recalls never overdue.

No test plan provided--obvious correction.

Sponsored-by: Ignatianum University in Cracow
Comment 2 Phil Ringnalda 2024-07-10 04:29:28 UTC
Created attachment 168688 [details] [review]
Bug 37271: Recall status should be 'requested' in overdue_recalls.pl

In "Bug 19532: Make recalls.status an ENUM" one-letter statuses were
replaced by their verbal equivalents.  But in overdue_recalls.pl
remained "R".  As a result, recalls never overdue.

No test plan provided--obvious correction.

Sponsored-by: Ignatianum University in Cracow
Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Comment 3 Katrin Fischer 2024-07-12 07:57:33 UTC
Picking this one from QA queue for review - thanks Janusz!
Comment 4 Katrin Fischer 2024-07-12 08:22:23 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 5 Lucas Gass (lukeg) 2024-11-18 18:13:32 UTC
Backported to 24.05.x for upcoming 24.05.06