Summary: | Default messaging preferences are not applied when self registering in OPAC | ||
---|---|---|---|
Product: | Koha | Reporter: | Andreas Jonsson <andreas.jonsson> |
Component: | OPAC | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | Pushed to oldstable --- | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
Severity: | normal | ||
Priority: | P5 - low | CC: | david, fridolin.somers, lisette, lucas, nick, wainuiwitikapark |
Version: | 23.05 | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34003 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This fixes a regression in Koha 24.05, 23.11, and 23.05 (caused by Bug 30318). Default messaging preferences for the self registraton patron category were not set for patron's self-registering using the OPAC.
|
Version(s) released in: |
24.11.00,24.05.05,23.11.10
|
Circulation function: | |||
Bug Depends on: | 30318 | ||
Bug Blocks: | |||
Attachments: |
Bug 37339: Set messaging preferences from default on self registration
Bug 37339: Set messaging preferences from default on self registration Bug 37339: Set messaging preferences from default on self registration |
Description
Andreas Jonsson
2024-07-12 08:30:30 UTC
Created attachment 168920 [details] [review] Bug 37339: Set messaging preferences from default on self registration The change on bug 30318 prevented setting the default messaging preferences when none were passed. Self registration relied on this for setting borrower preferences from the defaults. This patch removes the call to handle_form_action and replaces it with a call to: SetMessagingPreferencesFromDefault To test: 1 - Ensure self registration is enabled 2 - Set default messaging preferences for the self registration category 3 - Self register a patron from the OPAC, confirm defaults not set 4 - Apply patch, restart all 5 - Self register a patron 6 - Confirm defaults have been set 7 - Enable PatronSelfRegistrationVerifyByEmail 8 - Self register a patron on OPAC with an email 9 - Find the email and grab the verification link (unless you have emails enabled) SELECT * FROM message_queue; 10 - Visit the link and confirm registration 11 - Confirm messaging defaults are set Created attachment 168924 [details] [review] Bug 37339: Set messaging preferences from default on self registration The change on bug 30318 prevented setting the default messaging preferences when none were passed. Self registration relied on this for setting borrower preferences from the defaults. This patch removes the call to handle_form_action and replaces it with a call to: SetMessagingPreferencesFromDefault To test: 1 - Ensure self registration is enabled 2 - Set default messaging preferences for the self registration category 3 - Self register a patron from the OPAC, confirm defaults not set 4 - Apply patch, restart all 5 - Self register a patron 6 - Confirm defaults have been set 7 - Enable PatronSelfRegistrationVerifyByEmail 8 - Self register a patron on OPAC with an email 9 - Find the email and grab the verification link (unless you have emails enabled) SELECT * FROM message_queue; 10 - Visit the link and confirm registration 11 - Confirm messaging defaults are set Signed-off-by: David Nind <david@davidnind.com> Created attachment 169098 [details] [review] Bug 37339: Set messaging preferences from default on self registration The change on bug 30318 prevented setting the default messaging preferences when none were passed. Self registration relied on this for setting borrower preferences from the defaults. This patch removes the call to handle_form_action and replaces it with a call to: SetMessagingPreferencesFromDefault To test: 1 - Ensure self registration is enabled 2 - Set default messaging preferences for the self registration category 3 - Self register a patron from the OPAC, confirm defaults not set 4 - Apply patch, restart all 5 - Self register a patron 6 - Confirm defaults have been set 7 - Enable PatronSelfRegistrationVerifyByEmail 8 - Self register a patron on OPAC with an email 9 - Find the email and grab the verification link (unless you have emails enabled) SELECT * FROM message_queue; 10 - Visit the link and confirm registration 11 - Confirm messaging defaults are set Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> All makes sense, no QA issues, no regressions. Passing QA Just wondering: If we have: + C4::Members::Messaging::SetMessagingPreferencesFromDefaults Do we still need the use? +use C4::Members::Messaging qw( SetMessagingPreferencesFromDefaults ); Pushed for 24.11! Well done everyone, thank you! Backported to 24.05.x for upcoming 24.05.05 Pushed to 23.11.x for 23.11.10 Not backporting to 23.05.x unless requested |