Summary: | Patroncards barcode do not support EAN13 | ||
---|---|---|---|
Product: | Koha | Reporter: | wolfgang.apolinarski |
Component: | Label/patron card printing | Assignee: | Chris Nighswonger <cnighswonger> |
Status: | NEW --- | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | wolfgang.apolinarski |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Proposed patch
Proposed patch |
Description
wolfgang.apolinarski
2024-07-14 19:59:37 UTC
Created attachment 168951 [details] [review] Proposed patch I'm not sure I understand the need for the proposed refactor. EAN13 is supported for both labels and cards. Plaese add more details as to how to reproduce the problem you are having. Okay. EAN13 isn't supported in patron cards. My bad. EAN13 was added to labels after my work. However, it would be better at this point to duplicate the EAN13 code from label.pm in patroncards.pm as this touches much less code. There's a lot of cut and paste between these two scripts and they both need refactoring extensively. Thank you for your fast reaction! Should I just copy the code then from one class to the other? I actually considered that bad practice that is why I did not want to do that. Or would you create a patch, since you are the expert anyway? Created attachment 169011 [details] [review] Proposed patch Fixed missing CheckDigits for CODE39 (forgot import), tested that Bug 21123 is now also solved. This still introduces complication and provides an incomplete solution. If we are going to extract the barcode drawing code, we should be consistent and port this to the patron card code as well. All things considered, it is less complicated and less likely to introduce unintentional bugs to just paste over the small code block from labels to address the EAN13 option in patron cards. |