Bug 37362

Summary: Do not show the lists button if there are no public lists and opacuserlogin is off
Product: Koha Reporter: Owen Leonard <oleonard>
Component: OPACAssignee: Owen Leonard <oleonard>
Status: Signed Off --- QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low    
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 37362: Do not show the lists button if there are no public lists and opacuserlogin is off
Bug 37362: Do not show the lists button if there are no public lists and opacuserlogin is off
Bug 37362: Do not show the lists button if there are no public lists and opacuserlogin is off

Description Owen Leonard 2024-07-15 14:37:00 UTC
If all of the following are true:

- Lists are enabled (virtualshelves is on)
- opacuserlogin is turned off (users cannot create their own lists)
- There are no public lists

...then we should not show the "Lists" button in the OPAC header.
Comment 1 Owen Leonard 2024-07-15 14:46:15 UTC
Created attachment 168996 [details] [review]
Bug 37362: Do not show the lists button if there are no public lists and opacuserlogin is off

This patch updates the OPAC header so that if opacuserlogin is off and
there are no public shelves, the Lists button does not appear. If
opacuserlogin is turned off the only kind of lists the user can interact
with are public ones, and without public lists there's nothing to do.

To test, apply the patch and test the arrangement of the OPAC header in
these cases:

- opacuserlogin is on, user is logged in, and there are no public lists:
  - The Lists button appears and contains only "Your lists" menu items.
- opacuserlogin is on, user is logged in, and there are public lists:
  - The Lists button appears and the menu contains controls for both
    public and private lists.
- opacuserlogin is off and there are public lists:
  - The Lists button appears and shows only controls for public lists.
- opacuserlogin is off and there are no public lists:
  - The Lists button does not appear.

Sponsored-by: Athens County Public Libraries
Comment 2 Caroline Cyr La Rose 2024-07-15 16:56:16 UTC
Created attachment 169012 [details] [review]
Bug 37362: Do not show the lists button if there are no public lists and opacuserlogin is off

This patch updates the OPAC header so that if opacuserlogin is off and
there are no public shelves, the Lists button does not appear. If
opacuserlogin is turned off the only kind of lists the user can interact
with are public ones, and without public lists there's nothing to do.

To test, apply the patch and test the arrangement of the OPAC header in
these cases:

- opacuserlogin is on, user is logged in, and there are no public lists:
  - The Lists button appears and contains only "Your lists" menu items.
- opacuserlogin is on, user is logged in, and there are public lists:
  - The Lists button appears and the menu contains controls for both
    public and private lists.
- opacuserlogin is off and there are public lists:
  - The Lists button appears and shows only controls for public lists.
- opacuserlogin is off and there are no public lists:
  - The Lists button does not appear.

Sponsored-by: Athens County Public Libraries
Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Comment 3 Katrin Fischer 2024-09-02 08:28:43 UTC
I am sorry, but probably due to Bootsrap 5 changes this no longer applies cleanly and the differences are a bit hard to see for whitespace changes. Please rebase!
Comment 4 Owen Leonard 2024-09-04 13:43:08 UTC
Created attachment 171027 [details] [review]
Bug 37362: Do not show the lists button if there are no public lists and opacuserlogin is off

This patch updates the OPAC header so that if opacuserlogin is off and
there are no public shelves, the Lists button does not appear. If
opacuserlogin is turned off the only kind of lists the user can interact
with are public ones, and without public lists there's nothing to do.

To test, apply the patch and test the arrangement of the OPAC header in
these cases:

- opacuserlogin is on, user is logged in, and there are no public lists:
  - The Lists button appears and contains only "Your lists" menu items.
- opacuserlogin is on, user is logged in, and there are public lists:
  - The Lists button appears and the menu contains controls for both
    public and private lists.
- opacuserlogin is off and there are public lists:
  - The Lists button appears and shows only controls for public lists.
- opacuserlogin is off and there are no public lists:
  - The Lists button does not appear.

Sponsored-by: Athens County Public Libraries
Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>