| Summary: | Do not show the lists button if there are no public lists and opacuserlogin is off | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
| Status: | RESOLVED FIXED | QA Contact: | Laura Escamilla <Laura.escamilla> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | Laura.escamilla, lucas |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
24.11.00
|
|
| Circulation function: | |||
| Attachments: |
Bug 37362: Do not show the lists button if there are no public lists and opacuserlogin is off
Bug 37362: Do not show the lists button if there are no public lists and opacuserlogin is off Bug 37362: Do not show the lists button if there are no public lists and opacuserlogin is off Bug 37362: Do not show the lists button if there are no public lists and opacuserlogin is off |
||
|
Description
Owen Leonard
2024-07-15 14:37:00 UTC
Created attachment 168996 [details] [review] Bug 37362: Do not show the lists button if there are no public lists and opacuserlogin is off This patch updates the OPAC header so that if opacuserlogin is off and there are no public shelves, the Lists button does not appear. If opacuserlogin is turned off the only kind of lists the user can interact with are public ones, and without public lists there's nothing to do. To test, apply the patch and test the arrangement of the OPAC header in these cases: - opacuserlogin is on, user is logged in, and there are no public lists: - The Lists button appears and contains only "Your lists" menu items. - opacuserlogin is on, user is logged in, and there are public lists: - The Lists button appears and the menu contains controls for both public and private lists. - opacuserlogin is off and there are public lists: - The Lists button appears and shows only controls for public lists. - opacuserlogin is off and there are no public lists: - The Lists button does not appear. Sponsored-by: Athens County Public Libraries Created attachment 169012 [details] [review] Bug 37362: Do not show the lists button if there are no public lists and opacuserlogin is off This patch updates the OPAC header so that if opacuserlogin is off and there are no public shelves, the Lists button does not appear. If opacuserlogin is turned off the only kind of lists the user can interact with are public ones, and without public lists there's nothing to do. To test, apply the patch and test the arrangement of the OPAC header in these cases: - opacuserlogin is on, user is logged in, and there are no public lists: - The Lists button appears and contains only "Your lists" menu items. - opacuserlogin is on, user is logged in, and there are public lists: - The Lists button appears and the menu contains controls for both public and private lists. - opacuserlogin is off and there are public lists: - The Lists button appears and shows only controls for public lists. - opacuserlogin is off and there are no public lists: - The Lists button does not appear. Sponsored-by: Athens County Public Libraries Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> I am sorry, but probably due to Bootsrap 5 changes this no longer applies cleanly and the differences are a bit hard to see for whitespace changes. Please rebase! Created attachment 171027 [details] [review] Bug 37362: Do not show the lists button if there are no public lists and opacuserlogin is off This patch updates the OPAC header so that if opacuserlogin is off and there are no public shelves, the Lists button does not appear. If opacuserlogin is turned off the only kind of lists the user can interact with are public ones, and without public lists there's nothing to do. To test, apply the patch and test the arrangement of the OPAC header in these cases: - opacuserlogin is on, user is logged in, and there are no public lists: - The Lists button appears and contains only "Your lists" menu items. - opacuserlogin is on, user is logged in, and there are public lists: - The Lists button appears and the menu contains controls for both public and private lists. - opacuserlogin is off and there are public lists: - The Lists button appears and shows only controls for public lists. - opacuserlogin is off and there are no public lists: - The Lists button does not appear. Sponsored-by: Athens County Public Libraries Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Created attachment 171804 [details] [review] Bug 37362: Do not show the lists button if there are no public lists and opacuserlogin is off This patch updates the OPAC header so that if opacuserlogin is off and there are no public shelves, the Lists button does not appear. If opacuserlogin is turned off the only kind of lists the user can interact with are public ones, and without public lists there's nothing to do. To test, apply the patch and test the arrangement of the OPAC header in these cases: - opacuserlogin is on, user is logged in, and there are no public lists: - The Lists button appears and contains only "Your lists" menu items. - opacuserlogin is on, user is logged in, and there are public lists: - The Lists button appears and the menu contains controls for both public and private lists. - opacuserlogin is off and there are public lists: - The Lists button appears and shows only controls for public lists. - opacuserlogin is off and there are no public lists: - The Lists button does not appear. Sponsored-by: Athens County Public Libraries Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant Doesn;t apply clean to 24.05.x, rebase if needed. |