| Summary: | Orders search is not returning any results | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Rhonda Kuiper <rkuiper> |
| Component: | Acquisitions | Assignee: | Brendan Lawlor <blawlor> |
| Status: | RESOLVED FIXED | QA Contact: | Chris Cormack <chris> |
| Severity: | blocker | ||
| Priority: | P5 - low | CC: | blawlor, danielle.elder, david, ddaghita, fridolin.somers, lucas, sbrown |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This fixes the orders search in Acquisitions - clicking the search button was doing nothing and not returning any results. (This is related to the CSRF changes added in Koha 24.05 to improve form security.)
|
Version(s) released in: |
24.11.00,24.05.02
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 36192 | ||
| Attachments: |
Bug 37377: Fix orders search cud-do_search param
Bug 37377: Fix orders search do_search param Bug 37377: Fix orders search do_search param Bug 37377: Fix orders search do_search param |
||
|
Description
Rhonda Kuiper
2024-07-16 18:04:17 UTC
Confirmed in main. Upping severity. Created attachment 169164 [details] [review] Bug 37377: Fix orders search cud-do_search param This patch ifxes the orders searhc in Acquisitions. The parameteter needed to be prepended with cud- Test plan: 1. Create an order that you can search for 2. Try order search, nothing happens 3. Apply patch restart all, refresh browser 4. Try order seach again and get results Created attachment 169165 [details] [review] Bug 37377: Fix orders search do_search param This patch fixes the orders search in Acquisitions. The form method is GET no need to prepend with cud- Test plan: 1. Create an order that you can search for 2. Try order search, nothing happens 3. Apply patch restart all, refresh browser 4. Try order seach again and get results Created attachment 169168 [details] [review] Bug 37377: Fix orders search do_search param This patch fixes the orders search in Acquisitions. The form method is GET no need to prepend with cud- Test plan: 1. Create an order that you can search for 2. Try order search, nothing happens 3. Apply patch restart all, refresh browser 4. Try order seach again and get results Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Created attachment 169173 [details] [review] Bug 37377: Fix orders search do_search param This patch fixes the orders search in Acquisitions. The form method is GET no need to prepend with cud- Test plan: 1. Create an order that you can search for 2. Try order search, nothing happens 3. Apply patch restart all, refresh browser 4. Try order seach again and get results Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant Will this, can this, be backported to 24.05? +1 (In reply to Dani Elder from comment #7) > Will this, can this, be backported to 24.05? It should be - as it is fixing a bug introduced with the CSRF changes to improve form security. It has probably missed the 24.05.02 maintenance release planned for this month. Backported to 24.05.x for upcoming 24.05.02 Full CSRF not in 23.11.x No updates to the manual required - fixes something that was not working as it should. |