Bug 37377

Summary: Orders search is not returning any results
Product: Koha Reporter: Rhonda Kuiper <rkuiper>
Component: AcquisitionsAssignee: Brendan Lawlor <blawlor>
Status: RESOLVED FIXED QA Contact: Chris Cormack <chris>
Severity: blocker    
Priority: P5 - low CC: blawlor, danielle.elder, david, ddaghita, fridolin.somers, lucas, sbrown
Version: MainKeywords: RM_priority
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
This fixes the orders search in Acquisitions - clicking the search button was doing nothing and not returning any results. (This is related to the CSRF changes added in Koha 24.05 to improve form security.)
Version(s) released in:
24.11.00,24.05.02
Circulation function:
Bug Depends on:    
Bug Blocks: 36192    
Attachments: Bug 37377: Fix orders search cud-do_search param
Bug 37377: Fix orders search do_search param
Bug 37377: Fix orders search do_search param
Bug 37377: Fix orders search do_search param

Description Rhonda Kuiper 2024-07-16 18:04:17 UTC
When using the 'Orders search' feature on the Acquisitions home page, the search doesn't return any results.  This was working in 23.05.
Comment 1 Katrin Fischer 2024-07-18 11:29:10 UTC
Confirmed in main. Upping severity.
Comment 2 Brendan Lawlor 2024-07-18 18:19:19 UTC
Created attachment 169164 [details] [review]
Bug 37377: Fix orders search cud-do_search param

This patch ifxes the orders searhc in Acquisitions.

The parameteter needed to be prepended with cud-

Test plan:
1. Create an order that you can search for
2. Try order search, nothing happens
3. Apply patch restart all, refresh browser
4. Try order seach again and get results
Comment 3 Brendan Lawlor 2024-07-18 18:35:18 UTC
Created attachment 169165 [details] [review]
Bug 37377: Fix orders search do_search param

This patch fixes the orders search in Acquisitions.

The form method is GET no need to prepend with cud-

Test plan:
1. Create an order that you can search for
2. Try order search, nothing happens
3. Apply patch restart all, refresh browser
4. Try order seach again and get results
Comment 4 Roman Dolny 2024-07-18 21:00:57 UTC
Created attachment 169168 [details] [review]
Bug 37377: Fix orders search do_search param

This patch fixes the orders search in Acquisitions.

The form method is GET no need to prepend with cud-

Test plan:
1. Create an order that you can search for
2. Try order search, nothing happens
3. Apply patch restart all, refresh browser
4. Try order seach again and get results

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Comment 5 Chris Cormack 2024-07-19 02:00:13 UTC
Created attachment 169173 [details] [review]
Bug 37377: Fix orders search do_search param

This patch fixes the orders search in Acquisitions.

The form method is GET no need to prepend with cud-

Test plan:
1. Create an order that you can search for
2. Try order search, nothing happens
3. Apply patch restart all, refresh browser
4. Try order seach again and get results

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Comment 6 Martin Renvoize 2024-07-22 06:27:13 UTC
Thanks for all the hard work!

Pushed to main for the next 24.11.00 release as RM Assistant
Comment 7 Dani Elder 2024-07-22 15:47:31 UTC
Will this, can this, be backported to 24.05?
Comment 8 Rhonda Kuiper 2024-07-22 15:56:05 UTC
+1
Comment 9 David Nind 2024-07-22 19:52:12 UTC
(In reply to Dani Elder from comment #7)
> Will this, can this, be backported to 24.05?

It should be - as it is fixing a bug introduced with the CSRF changes to improve form security.

It has probably missed the 24.05.02 maintenance release planned for this month.
Comment 10 Lucas Gass 2024-07-24 20:11:53 UTC
Backported to 24.05.x for upcoming 24.05.02
Comment 11 Fridolin Somers 2024-07-25 07:49:21 UTC
Full CSRF not in 23.11.x
Comment 12 David Nind 2024-07-29 23:10:38 UTC
No updates to the manual required - fixes something that was not working as it should.