Bug 37418

Summary:	Expand delete_patron.pl / Patrons with defined restrictions should not be deleted
Product:	Koha	Reporter:	Michaela Sieber <michaela.sieber>
Component:	Patrons	Assignee:	Raphael Straub <raphael.straub>
Status:	Signed Off ---	QA Contact:	Testopia <testopia>
Severity:	enhancement
Priority:	P5 - low	CC:	clemens.tubach, gmcharlt, kyle.m.hall, lauren_denny
Version:	unspecified
Hardware:	All
OS:	All
Change sponsored?:	Sponsored	Patch complexity:	Small patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Attachments:	Bug 37418: delete_patrons.pl: Exclude patrons with restrictions Bug 37418: delete_patrons.pl: Exclude patrons with restrictions

Description Michaela Sieber 2024-07-22 08:13:17 UTC

In some cases we don't want borrowers / patrons not to be deleted if they have certain restrictions.
Therefor we add a new parameter to the cronjob delete_patrons.pl
(see manual  
https://koha-community.org/manual/latest/en/html/cron_jobs.html#batch-delete-patrons )

Comment 1 Raphael Straub 2024-07-26 10:28:09 UTC

Created attachment 169688 [details] [review]
Bug 37418: delete_patrons.pl: Exclude patrons with restrictions

Add the option "--without_restriction_type" so that delete_patrons.pl
does not delete patrons with given restriction types.

To test:
1) Run
   misc/cronjobs/delete_patrons.pl --not_borrowed_since 2010-01-01
   and choose a borrowernumber that would be deleted.
2) In your browser go to
   /cgi-bin/koha/members/moremember.pl?borrowernumber=<borrowernumber>
   and add a manual restriction to this patron.
3) Apply the patch.
4) Run
   misc/cronjobs/delete_patrons.pl --not_borrowed_since 2010-01-01 \
       --without_restriction_type MANUAL
5) Check that the patron with the manual restriction would not be
   deleted.

Sponsored-by: Karlsruhe Institute of Technology (KIT)

Comment 2 Roman Dolny 2024-07-30 21:43:13 UTC

Created attachment 169879 [details] [review]
Bug 37418: delete_patrons.pl: Exclude patrons with restrictions

Add the option "--without_restriction_type" so that delete_patrons.pl
does not delete patrons with given restriction types.

To test:
1) Run
   misc/cronjobs/delete_patrons.pl --not_borrowed_since 2010-01-01
   and choose a borrowernumber that would be deleted.
2) In your browser go to
   /cgi-bin/koha/members/moremember.pl?borrowernumber=<borrowernumber>
   and add a manual restriction to this patron.
3) Apply the patch.
4) Run
   misc/cronjobs/delete_patrons.pl --not_borrowed_since 2010-01-01 \
       --without_restriction_type MANUAL
5) Check that the patron with the manual restriction would not be
   deleted.

Sponsored-by: Karlsruhe Institute of Technology (KIT)
Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>