| Summary: | Deletion of bibliographic record can cause search errors | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | Staff interface | Assignee: | Nick Clemens (kidclamp) <nick> |
| Status: | Pushed to oldstable --- | QA Contact: | Julian Maurice <julian.maurice> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | cj.lynce, dcook, fridolin.somers, gmcharlt, julian.maurice, lucas, wainuiwitikapark |
| Version: | Main | Keywords: | rel_23_11_candidate |
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
24.11.00,24.05.04,23.11.09
|
|
| Circulation function: | |||
| Bug Depends on: | 35558 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 37425: Check for existence of biblio object before fetching cover images
Bug 37425: Check for existence of biblio object before fetching cover images Bug 37425: Check for existence of biblio object before fetching cover images |
||
|
Description
Nick Clemens (kidclamp)
2024-07-22 19:46:05 UTC
Created attachment 169380 [details] [review] Bug 37425: Check for existence of biblio object before fetching cover images This patch simply adds a conditional to ensure the biblio object has been retrieved and assumes no cover images otherwise To test: 1 - Enable system preference LocalCoverImages 2 - Perform a search in staff interface 3 - Find the biblionumebr for one of the results and delete it via the SQL backend: DELETE FROM biblio WHERE biblionumber=3; 4 - Search again. 5 - KO! Can't call method "cover_images" on an undefined value at /usr/share/koha/intranet/cgi-bin/catalogue/search.pl line 671. 6 - Reindex, confirm error is gone 7 - Apply patch 8 - Search again 9 - Delete a record from the results via SQL 10 - Reload and confirm no error 11 - Reindex and repeat search and confirm no error Created attachment 169425 [details] [review] Bug 37425: Check for existence of biblio object before fetching cover images This patch simply adds a conditional to ensure the biblio object has been retrieved and assumes no cover images otherwise To test: 1 - Enable system preference LocalCoverImages 2 - Perform a search in staff interface 3 - Find the biblionumebr for one of the results and delete it via the SQL backend: DELETE FROM biblio WHERE biblionumber=3; 4 - Search again. 5 - KO! Can't call method "cover_images" on an undefined value at /usr/share/koha/intranet/cgi-bin/catalogue/search.pl line 671. 6 - Reindex, confirm error is gone 7 - Apply patch 8 - Search again 9 - Delete a record from the results via SQL 10 - Reload and confirm no error 11 - Reindex and repeat search and confirm no error Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Created attachment 169495 [details] [review] Bug 37425: Check for existence of biblio object before fetching cover images This patch simply adds a conditional to ensure the biblio object has been retrieved and assumes no cover images otherwise To test: 1 - Enable system preference LocalCoverImages 2 - Perform a search in staff interface 3 - Find the biblionumebr for one of the results and delete it via the SQL backend: DELETE FROM biblio WHERE biblionumber=3; 4 - Search again. 5 - KO! Can't call method "cover_images" on an undefined value at /usr/share/koha/intranet/cgi-bin/catalogue/search.pl line 671. 6 - Reindex, confirm error is gone 7 - Apply patch 8 - Search again 9 - Delete a record from the results via SQL 10 - Reload and confirm no error 11 - Reindex and repeat search and confirm no error Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Trivial patch. QA script doesn't complain. Passed QA Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant A kind request to backport to 24.05? Thx! Yeah this will need to be backported all the way back to 23.11 (In reply to David Cook from comment #7) > Yeah this will need to be backported all the way back to 23.11 You can use the rel_ keywords to indicate that to the RMaints. Backported to 24.05.x for upcoming 24.05.04 Don't we need the same on opac/opac-search.pl ? Pushed to 23.11.x for 23.11.09 Not backporting to 23.05.x unless requested |