Summary: | Warning 'Use of uninitialized value $f/$d in hash element...' in log when sorting by relevance | ||
---|---|---|---|
Product: | Koha | Reporter: | Janusz Kaczmarek <januszop> |
Component: | Searching - Elasticsearch | Assignee: | Janusz Kaczmarek <januszop> |
Status: | RESOLVED DUPLICATE | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | m.de.rooy |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 37433: Warning 'Use of uninitialized value $f/$d in hash element...' in log when sorting by relevance
Bug 37433: Warning 'Use of uninitialized value $f/$d in hash element...' in log when sorting by relevance |
Description
Janusz Kaczmarek
2024-07-23 12:47:10 UTC
Created attachment 169418 [details] [review] Bug 37433: Warning 'Use of uninitialized value $f/$d in hash element...' in log when sorting by relevance With ES, searches with Sort set to Relevance produce following warnings in log file: [WARN] Use of uninitialized value $f in hash element at /kohadevbox/koha/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm line 728. [WARN] Use of uninitialized value $d in hash element at /kohadevbox/koha/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm line 728. This is because sort_by = 'relevance' does not contain underscore. Test plan: ========== 1. Have a test environment with ES enabled. 2. Perform a search for a common word (like 'greek'). Make sure that the sort order is set to 'Relevance' (the default option in ktd). Check the content of the plack-intranet-error.log file--you should see warning lines with a messages "Use of uninitialized value $f in hash element ..." "Use of uninitialized value $d in hash element ..." 3. Apply the patch; restart_all. 4. Repeat p. 2. The log should be clean now. Sponsored-by: Ignatianum University in Cracow Created attachment 169422 [details] [review] Bug 37433: Warning 'Use of uninitialized value $f/$d in hash element...' in log when sorting by relevance With ES, searches with Sort set to Relevance produce following warnings in log file: [WARN] Use of uninitialized value $f in hash element at /kohadevbox/koha/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm line 728. [WARN] Use of uninitialized value $d in hash element at /kohadevbox/koha/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm line 728. This is because sort_by = 'relevance' does not contain underscore. Test plan: ========== 1. Have a test environment with ES enabled. 2. Perform a search for a common word (like 'greek'). Make sure that the sort order is set to 'Relevance' (the default option in ktd). Check the content of the plack-intranet-error.log file--you should see warning lines with a messages "Use of uninitialized value $f in hash element ..." "Use of uninitialized value $d in hash element ..." 3. Apply the patch; restart_all. 4. Repeat p. 2. The log should be clean now. Sponsored-by: Ignatianum University in Cracow Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> |