| Summary: | Cannot renew patron from details page in patron account without circulate permissions | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
| Component: | Patrons | Assignee: | Eric Garcia <cubingguy714> |
| Status: | Pushed to oldstable --- | QA Contact: | Emily Lamancusa (emlam) <emily.lamancusa> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | emily.lamancusa, fridolin.somers, gmcharlt, hebah, kyle.m.hall, martin.renvoize, wainuiwitikapark |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
24.11.00,24.05.04,23.11.09
|
|
| Circulation function: | |||
| Attachments: |
Bug 37435: Fixed renew patron from moremember.pl without circulate permissions
Bug 37435: Fixed renew patron from moremember.pl without circulate permissions Bug 37435: Fixed renew patron from moremember.pl without circulate permissions |
||
Created attachment 169439 [details] [review] Bug 37435: Fixed renew patron from moremember.pl without circulate permissions To recreate: 1. Have a staff account with limited permissions: -Staff access ( catalouge ) -Add, modify and view patron information (borrowers) -NO circulate permissions 2. Log in as that staff user and find a patron with an expired account. 3. See the warning "Expiration: Patron's card has expired. Renew or Edit details". 4. Try clicking on Renew, you are logged out and see "Error: You do not have permission to access this page." To test: 1. Apply patch 2. From the expired patron's details page see the warning and click Renew 3. Notice it renews the patron and returns to the patron details page 4. Details -> Edit -> Set the expiration date so that the patron is expired 5. Go back to your staff patron and check 'Check out and check in items' permission 6. In your expired patron's page -> Check out -> See warning -> Renew 7. Notice it renews the patron and returns to the check out page 8. Set the expired patron's expiration date so that it expires soon 9. Uncheck 'Check out and check in items' permission for your staff patron 10. Confirm the warning for your patron now is "Expiration: Patron's card expires on (DATE). Renew or Edit details" 11. Repeat steps 2-7 and notice it returns to the correct pages Created attachment 169513 [details] [review] Bug 37435: Fixed renew patron from moremember.pl without circulate permissions To recreate: 1. Have a staff account with limited permissions: -Staff access ( catalouge ) -Add, modify and view patron information (borrowers) -NO circulate permissions 2. Log in as that staff user and find a patron with an expired account. 3. See the warning "Expiration: Patron's card has expired. Renew or Edit details". 4. Try clicking on Renew, you are logged out and see "Error: You do not have permission to access this page." To test: 1. Apply patch 2. From the expired patron's details page see the warning and click Renew 3. Notice it renews the patron and returns to the patron details page 4. Details -> Edit -> Set the expiration date so that the patron is expired 5. Go back to your staff patron and check 'Check out and check in items' permission 6. In your expired patron's page -> Check out -> See warning -> Renew 7. Notice it renews the patron and returns to the check out page 8. Set the expired patron's expiration date so that it expires soon 9. Uncheck 'Check out and check in items' permission for your staff patron 10. Confirm the warning for your patron now is "Expiration: Patron's card expires on (DATE). Renew or Edit details" 11. Repeat steps 2-7 and notice it returns to the correct pages Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Created attachment 169567 [details] [review] Bug 37435: Fixed renew patron from moremember.pl without circulate permissions To recreate: 1. Have a staff account with limited permissions: -Staff access ( catalouge ) -Add, modify and view patron information (borrowers) -NO circulate permissions 2. Log in as that staff user and find a patron with an expired account. 3. See the warning "Expiration: Patron's card has expired. Renew or Edit details". 4. Try clicking on Renew, you are logged out and see "Error: You do not have permission to access this page." To test: 1. Apply patch 2. From the expired patron's details page see the warning and click Renew 3. Notice it renews the patron and returns to the patron details page 4. Details -> Edit -> Set the expiration date so that the patron is expired 5. Go back to your staff patron and check 'Check out and check in items' permission 6. In your expired patron's page -> Check out -> See warning -> Renew 7. Notice it renews the patron and returns to the check out page 8. Set the expired patron's expiration date so that it expires soon 9. Uncheck 'Check out and check in items' permission for your staff patron 10. Confirm the warning for your patron now is "Expiration: Patron's card expires on (DATE). Renew or Edit details" 11. Repeat steps 2-7 and notice it returns to the correct pages Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Looks good, fixes the problem and QA tool passes. Passing QA. Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant Backported to 24.05.x for upcoming 24.05.04 Pushed to 23.11.x for 23.11.09 Had to adapt because in 23.11 op=modify instead of op=edit_form Not backporting to 23.05.x unless requested |
To recreate: 1. Have a staff account with limited permissions: -Staff access ( catalouge ) -Add, modify and view patron information (borrowers) -NO circulate permissions 2. Log in as that staff user and find a patron with an expired account. 3. See the warning "Expiration: Patron's card has expired. Renew or Edit details". 4. Try clicking on Renew, you are logged out and see "Error: You do not have permission to access this page."