Bug 37450

Summary:	Clicking 'Close basket' from the list of baskets does nothing
Product:	Koha	Reporter:	Kelly McElligott <kelly>
Component:	Acquisitions	Assignee:	Sam Lau <samalau>
Status:	Needs documenting ---	QA Contact:	Laura Escamilla <Laura.escamilla>
Severity:	trivial
Priority:	P5 - low	CC:	fridolin.somers, Laura.escamilla, lucas, samalau
Version:	24.05
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	---
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	24.11.00,24.05.04
Circulation function:
Attachments:	Bug 37450: Fix 'Close basket' button from list of baskets Bug 37450: Fix 'Close basket' button from list of baskets Bug 37450: Fix 'Close basket' button from list of baskets

Description Kelly McElligott 2024-07-24 13:29:17 UTC

From the list of baskets with a specific vendor, there is an action button which will allow users to close the basket. 
Clicking on this option will not close the basket and brings the user to a page 

koha/acqui/basket.pl?op=close&basketno=84&booksellerid=6

And the page will display this: New Basket () for

There are still Basket options on this page, but choosing to close the basket, will give the message, Vendor Not Found.

Choosing to edit the basket from this page, will give a 500 error.

Comment 1 Sam Lau 2024-07-24 16:58:09 UTC

Created attachment 169510 [details] [review]
Bug 37450: Fix 'Close basket' button from list of baskets

To test:
1) In acquisitions, have a vendor with an item (or items) in their basket. Search for this vendor.
2) From the actions column, select the arrow and then press 'Close this basket'
3) Clicking on this option will not close the basket and brings us to the wrong page
4) Apply patch
5) Try to close the basket again, and this time, it is closed successfully

Comment 2 Kelly McElligott 2024-07-24 17:33:24 UTC

Sam - should the status be 'needs sign-off'?

Comment 3 Roman Dolny 2024-07-25 15:09:13 UTC

Created attachment 169565 [details] [review]
Bug 37450: Fix 'Close basket' button from list of baskets

To test:
1) In acquisitions, have a vendor with an item (or items) in their basket. Search for this vendor.
2) From the actions column, select the arrow and then press 'Close this basket'
3) Clicking on this option will not close the basket and brings us to the wrong page
4) Apply patch
5) Try to close the basket again, and this time, it is closed successfully

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>

Comment 4 Laura Escamilla 2024-08-06 13:24:41 UTC

Created attachment 170100 [details] [review]
Bug 37450: Fix 'Close basket' button from list of baskets

QA tool is happy and the patch works great. Passing QA!

Comment 5 Katrin Fischer 2024-08-09 15:37:11 UTC

Pushed for 24.11!

Well done everyone, thank you!

Comment 6 Lucas Gass (lukeg) 2024-09-11 16:21:20 UTC

Backported to 24.05.x for upcoming 24.05.04

Comment 7 Fridolin Somers 2024-09-25 08:43:24 UTC

"cud-" not in 23.11.x