| Summary: | Make C4::Serials::addroutingmember use Koha::Objects | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> | 
| Component: | Architecture, internals, and plumbing | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> | 
| Status: | RESOLVED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> | 
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | caroline.cyr-la-rose, jonathan.druart, lucas, tomascohen | 
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 | 
| Patch complexity: | --- | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: | 
       24.11.00 
 | 
        
        Circulation function: | |
| Bug Depends on: | 37476 | ||
| Bug Blocks: | 37876 | ||
| Attachments: | 
              Bug 37480: Make addroutingmember use Koha::Subscription::Routinglists
               Bug 37480: Make addroutingmember use Koha::Subscription::Routinglists Bug 37480: Make addroutingmember use Koha::Subscription::Routinglists  | 
      ||
| 
 
        
          Description
        
        
          Tomás Cohen Arazi (tcohen)
        
        
        
        
          2024-07-25 17:31:50 UTC
        
       
    I initially wrote this as part of bug 37476 then decided to move it to it's own place. Created attachment 169608 [details] [review] Bug 37480: Make addroutingmember use Koha::Subscription::Routinglists This patch rewriteis the method so it relies on Koha::Object-based classes instead of the old way. To test: 1. Run: $ ktd --shell k$ prove t/db_dependent/Serials.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! 4. Run: $ git grep addroutingmember => SUCCESS: It is only called on a single .pl file which doesn't care about the return value. Neither the tests care. 5. Sign off :-D Created attachment 169796 [details] [review] Bug 37480: Make addroutingmember use Koha::Subscription::Routinglists This patch rewriteis the method so it relies on Koha::Object-based classes instead of the old way. To test: 1. Run: $ ktd --shell k$ prove t/db_dependent/Serials.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! 4. Run: $ git grep addroutingmember => SUCCESS: It is only called on a single .pl file which doesn't care about the return value. Neither the tests care. 5. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> Created attachment 171240 [details] [review] Bug 37480: Make addroutingmember use Koha::Subscription::Routinglists This patch rewriteis the method so it relies on Koha::Object-based classes instead of the old way. To test: 1. Run: $ ktd --shell k$ prove t/db_dependent/Serials.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! 4. Run: $ git grep addroutingmember => SUCCESS: It is only called on a single .pl file which doesn't care about the return value. Neither the tests care. 5. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> I've tested the feature. This test plan is cheating :D I agree with Joubu about the cheating with the test plan. *stern look* Pushed for 24.11! Well done everyone, thank you! (In reply to Jonathan Druart from comment #5) > I've tested the feature. This test plan is cheating :D I forgot about the test plan IMHO. Skipping for release notes as this is quite technical and kind of self-explanatory to developers. Internal architecture, nothing to add/edit in the manual.  |