Bug 37484

Summary: Sorting dates in the housebound deliveries table should work for different date formats
Product: Koha Reporter: Lucas Gass (lukeg) <lucas>
Component: Staff interfaceAssignee: Lucas Gass (lukeg) <lucas>
Status: RESOLVED FIXED QA Contact: Marcel de Rooy <m.de.rooy>
Severity: trivial    
Priority: P5 - low CC: gmcharlt, m.de.rooy, rkuiper
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00
Circulation function:
Bug Depends on: 34660    
Bug Blocks:    
Attachments: Bug 37484: Add data-order attribute to housebound delivery table
Bug 37484: Add data-order attribute to housebound delivery table
Bug 37484: Add data-order attribute to housebound delivery table

Description Lucas Gass (lukeg) 2024-07-25 21:08:49 UTC
The housebound deliveries table has a "Date" column what can sometimes sort wrong becasuse the data can look like this: 

07/01/2024 (morning)
07/01/2024 (afternoon)
07/02/2024 (morning) 


We can easily solve that by adding a data-order attribute.
Comment 1 Lucas Gass (lukeg) 2024-07-25 21:13:18 UTC
Created attachment 169615 [details] [review]
Bug 37484: Add data-order attribute to housebound delivery table

To test:
0. APPLY PATCH
1. Enable the HouseboundModule and set at least one staff person a Chooser and and Deliverer.
2. From a patron account go to the "Housebound" tab and schedule some deliveries.
3. See that each <td> in the Date column now includes a 'data-order' attribute in an ISO date format ( 2024-07-01 ) for better sorting.
Comment 2 Owen Leonard 2024-07-26 16:18:42 UTC
Created attachment 169753 [details] [review]
Bug 37484: Add data-order attribute to housebound delivery table

To test:
0. APPLY PATCH
1. Enable the HouseboundModule and set at least one staff person a
   Chooser and and Deliverer.
2. From a patron account go to the "Housebound" tab and schedule some
   deliveries.
3. See that each <td> in the Date column now includes a 'data-order'
   attribute in an ISO date format ( 2024-07-01 ) for better sorting.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Marcel de Rooy 2024-08-16 07:36:06 UTC
Created attachment 170434 [details] [review]
Bug 37484: Add data-order attribute to housebound delivery table

To test:
0. APPLY PATCH
1. Enable the HouseboundModule and set at least one staff person a
   Chooser and and Deliverer.
2. From a patron account go to the "Housebound" tab and schedule some
   deliveries.
3. See that each <td> in the Date column now includes a 'data-order'
   attribute in an ISO date format ( 2024-07-01 ) for better sorting.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Katrin Fischer 2024-08-19 15:31:10 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 5 Lucas Gass (lukeg) 2024-09-12 22:08:38 UTC
Enhancement wont be backported to 24.05.x