Summary: | Handle redirects in SUSHI requests | ||
---|---|---|---|
Product: | Koha | Reporter: | Matt Blenkinsop <matt.blenkinsop> |
Component: | ERM | Assignee: | Matt Blenkinsop <matt.blenkinsop> |
Status: | RESOLVED FIXED | QA Contact: | Nick Clemens (kidclamp) <nick> |
Severity: | major | ||
Priority: | P5 - low | CC: | belal.ahmadi, david, jonathan.druart, jonathan.field, kyle, lucas, martin.renvoize, matt.blenkinsop, michaela.sieber, pedro.amorim |
Version: | Main | Keywords: | rel_23_11_candidate |
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
24.11.00
|
Circulation function: | |
Bug Depends on: | 37856 | ||
Bug Blocks: | |||
Attachments: |
Bug 37526: Handle redirects in SUSHI requests
Bug 37526: Handle redirects in SUSHI requests Bug 37526: Add tests Bug 37526: Handle redirects in SUSHI requests Bug 37526: Add tests Bug 37526: Handle redirects in SUSHI requests Bug 37526: Add tests Bug 37526: Handle redirects in SUSHI requests Bug 37526: (QA follow-up) Tidy |
Description
Matt Blenkinsop
2024-07-30 12:53:40 UTC
Created attachment 169858 [details] [review] Bug 37526: Handle redirects in SUSHI requests Created attachment 170381 [details] [review] Bug 37526: Handle redirects in SUSHI requests Not sure how to test this one... Created attachment 171777 [details] [review] Bug 37526: Add tests Created attachment 171778 [details] [review] Bug 37526: Handle redirects in SUSHI requests Test plan: 1) Apply test patch only. Run: prove t/db_dependent/Koha/BackgroundJob/ErmSushiHarvester.t 2) Verify tests fail. 3) Apply this patch. Run tests again. Verify they pass. PA amended: Added test plan I've added bug 37856 as dependency as that builds on top of bug 37963. The tests patch I added here sits on top of it all so to prevent conflicts I've set the dependency as is. (In reply to David Nind from comment #3) > Not sure how to test this one... Test plan is now provided on the patch. Bug 37963 lays the groundwork to Mock SUSHI responses, so we can write tests that emulate what we and our customers are experiencing, without requiring the people testing it to have SUSHI credentials. Created attachment 171891 [details] [review] Bug 37526: Add tests Signed-off-by: David Nind <david@davidnind.com> Created attachment 171892 [details] [review] Bug 37526: Handle redirects in SUSHI requests Test plan: 1) Apply test patch only. Run: prove t/db_dependent/Koha/BackgroundJob/ErmSushiHarvester.t 2) Verify tests fail. 3) Apply this patch. Run tests again. Verify they pass. PA amended: Added test plan Signed-off-by: David Nind <david@davidnind.com> (In reply to Pedro Amorim from comment #6) > I've added bug 37856 as dependency as that builds on top of bug 37963. > The tests patch I added here sits on top of it all so to prevent conflicts > I've set the dependency as is. > > (In reply to David Nind from comment #3) > > Not sure how to test this one... > > Test plan is now provided on the patch. Bug 37963 lays the groundwork to > Mock SUSHI responses, so we can write tests that emulate what we and our > customers are experiencing, without requiring the people testing it to have > SUSHI credentials. Thanks Pedro! Created attachment 172055 [details] [review] Bug 37526: Add tests Signed-off-by: David Nind <david@davidnind.com> Created attachment 172056 [details] [review] Bug 37526: Handle redirects in SUSHI requests Test plan: 1) Apply test patch only. Run: prove t/db_dependent/Koha/BackgroundJob/ErmSushiHarvester.t 2) Verify tests fail. 3) Apply this patch. Run tests again. Verify they pass. PA amended: Added test plan Signed-off-by: David Nind <david@davidnind.com> Created attachment 172057 [details] [review] Bug 37526: (QA follow-up) Tidy Thanks for QA, Nick. Adding 24.05 and 23.11 release candidate keywords as this improves how the SUSHI response is handled widening the pool of providers Koha is able to work with. Pushed for 24.11! Well done everyone, thank you! Backported to 24.05.x for upcoming 24.05.06 (In reply to Lucas Gass (lukeg) from comment #15) > Backported to 24.05.x for upcoming 24.05.06 Actually tests fail with this applied, no backport. |