Bug 37538

Summary: Improve documentation printed by connexion_import_daemon.pl --help
Product: Koha Reporter: Rudolf Byker <rudolfbyker>
Component: Command-line UtilitiesAssignee: Rudolf Byker <rudolfbyker>
Status: Signed Off --- QA Contact: Lisette Scheer <lisette>
Severity: enhancement    
Priority: P5 - low CC: david, dcook, lisette, robin, rudolfbyker
Version: Main   
Hardware: All   
OS: All   
GIT URL: Initiative type: ---
Sponsorship status: Sponsored Crowdfunding goal: 0
Patch complexity: String patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on:    
Bug Blocks: 37539    
Attachments: Improve output of `connexion_import_daemon.pl --help`
Bug 37538: Improve documentation for the OCLC import daemon script.
Improve documentation for the OCLC import daemon script.
Bug 37538: Improve documentation for the OCLC import daemon script.
Bug 37538: Improve documentation for the OCLC import daemon script

Description Rudolf Byker 2024-07-31 14:35:36 UTC
Patch incoming :)

See related discussions at:

- https://chat.koha-community.org/koha-community/pl/o18q57a1pt879dgp63ujtcajpe
- https://chat.koha-community.org/koha-community/pl/gz3mjusns3bdme3j4f8sp83sfw
- https://chat.koha-community.org/koha-community/pl/yzxmrfegcbnrjgqgjt7t6wjwhy

I plan to follow this up with a patch for the koha-manual, which I will also link here.
Comment 1 Rudolf Byker 2024-07-31 14:52:42 UTC
Created attachment 169894 [details] [review]
Improve output of `connexion_import_daemon.pl --help`

Patch attached.
Comment 2 David Cook 2024-08-01 00:12:50 UTC
Created attachment 169921 [details] [review]
Bug 37538: Improve documentation for the OCLC import daemon script.

To test:
1) Run `/usr/share/koha/bin/connexion_import_daemon.pl --help`
2) Read the output and check for errors, whether grammatical, spelling, or factual.

Sponsored-by: Reformational Study Centre <www.refstudycentre.com>
Signed-off-by: David Cook <dcook@prosentient.com.au>
Comment 3 David Cook 2024-08-01 00:14:57 UTC
Patch works as described.

Test plan should use "./misc/bin/connexion_import_daemon.pl --help" rather than "/usr/share/koha/bin/connexion_import_daemon.pl --help" but not a problem

I'm not sure that the format is quite inline with other Koha scripts... but it looks like a very useful change. I haven't verified the truth of all the text changes, but they look good at a glance, and much more helpful than the current help text.
Comment 4 Rudolf Byker 2024-08-01 03:04:56 UTC
I'm not sure what you mean by the format not being in line with other scripts. I'm willing to improve it. I'm also willing to just let it go, and eager to get it merged, so that I can refer users to the script's --help output from the manual.
Comment 5 David Cook 2024-08-01 03:39:34 UTC
(In reply to Rudolf Byker from comment #4)
> I'm not sure what you mean by the format not being in line with other
> scripts. 

Say in comparison to the scripts in /usr/sbin/koha-*

> I'm willing to improve it. I'm also willing to just let it go, and
> eager to get it merged, so that I can refer users to the script's --help
> output from the manual.

I think that we can just let it go. Honestly, I don't think I have any specific recommendations on how to improve it either. A QAer might have some thoughts on this one, but with a script like this which is so rarely used... I think the more documentation the better in any case.
Comment 6 David Nind 2024-08-01 21:22:23 UTC
I changed the status to "Needs documenting".

Because of the way the Koha workflow is set up in Bugzilla (aimed at changes to the Koha code base), I needed to change the status a few times to get the right status shown:
1. RESOLVED FIXED
2. REOPENED
3. Needs documenting

The status can be changed to RESOLVED FIXED once the merge request goes through.
Comment 7 David Cook 2024-08-01 23:27:45 UTC
(In reply to David Nind from comment #6)
> I changed the status to "Needs documenting".
>
> The status can be changed to RESOLVED FIXED once the merge request goes
> through.

What needs documenting for this one? Is it just for the release notes or something else? this change shouldn't affect the manual?
Comment 8 David Nind 2024-08-01 23:43:05 UTC
(In reply to David Cook from comment #7)
> (In reply to David Nind from comment #6)
> > I changed the status to "Needs documenting".
> >
> > The status can be changed to RESOLVED FIXED once the merge request goes
> > through.
> 
> What needs documenting for this one? Is it just for the release notes or
> something else? this change shouldn't affect the manual?

OOPS, I updated the wrong bug! (Should have been bug 37539!)

Thanks for spotting, David.

Have changed back to Signed Off....
Comment 9 Lisette Scheer 2024-12-30 18:39:36 UTC
Patch failed to apply. Please rebase.

M	misc/bin/connexion_import_daemon.pl
Falling back to patching base and 3-way merge...
Auto-merging misc/bin/connexion_import_daemon.pl
CONFLICT (content): Merge conflict in misc/bin/connexion_import_daemon.pl
error: Failed to merge in the changes.
Patch failed at 0001 Bug 37538: Improve documentation for the OCLC import daemon script.
Comment 10 Rudolf Byker 2025-10-04 19:20:21 UTC
Created attachment 187431 [details] [review]
Improve documentation for the OCLC import daemon script.

Rebased :) Sorry for leaving this hanging for so long.
Comment 11 David Nind 2025-10-06 02:11:16 UTC Comment hidden (obsolete)
Comment 12 David Nind 2025-10-06 02:12:25 UTC
Created attachment 187435 [details] [review]
Bug 37538: Improve documentation for the OCLC import daemon script

This updates the documentation for the
misc/bin/connexion_import_daemon.pl --help option.

Test plan:
1. Run ./misc/bin/connexion_import_daemon.pl --help
2. Read the output and check for errors, whether grammatical,
   spelling, or factual.

Sponsored-by: Reformational Study Centre <www.refstudycentre.com>
Signed-off-by: David Cook <dcook@prosentient.com.au>
Signed-off-by: David Nind <david@davidnind.com>
Comment 13 David Nind 2025-10-06 02:14:42 UTC
I've signed off.

I've tidied up the patch a little, but haven't tested the options for the commands:
1. Terminology: intranet to staff interface
2. Terminology: e.g. to for example
3. Terminology: i.e. to that is
4. Line length to 79/80