| Summary: | Race condition in CHECKIN notices | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | Notices | Assignee: | Bugs List <koha-bugs> |
| Status: | NEW --- | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | dcook, jonathan.druart |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 15854 | ||
| Bug Blocks: | |||
|
Description
Nick Clemens (kidclamp)
2024-08-01 16:31:32 UTC
Yikes... that's not good. C4/Letters.pm
@@ -1038,7 +1038,7 @@ sub SendQueuedMessages {
$domain_limits = Koha::Notice::Util->load_domain_limits; # (re)initialize per run
while( ( my $message_object = $unsent_messages->next ) && ( !$limit || $count_messages < $limit ) ) {
- my $message = $message_object->unblessed;
+ my $message = $message_object->get_from_storage->unblessed;
What about refetching the letter at the start of the loop? It's cheap and could reduce this problem.
|