Summary: | new sys prefs - no way to add a new local use preference | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | System Administration | Assignee: | Chris Nighswonger <cnighswonger> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | blocker | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | cnighswonger, f.demians, gmcharlt, henridamien, jwagner |
Version: | rel_3_2 | ||
Hardware: | PC | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
local use 1
local use 2 local use 3 |
Description
Chris Cormack
2010-05-21 01:14:37 UTC
new wiki page here: http://wiki.koha-community.org/wiki/Koha_as_a_CMS and in the manual here: http://koha-community.org/documentation/3-2-manual/?ch=a9514 Updating version as described in http://wiki.koha-community.org/wiki/General_IRC_Meeting,_7_July_2010 This patch includes a bunch of system preferences on the local use tab that need to be removed - no sys prefs that can be found on other tabs should be on this list. Could you enumerate which prefs you are seeing? This patch hides all non-local prefs in the current head. okay i'm confused - i don't see them anymore, but i also don't see a way to create a local use preference anymore either. Found it. Okay if you go to sys prefs and click on the local use tab i see how to add a new pref, but i have a ton of prefs showing - see the screenshots. the prefs i have are: acquisitions AnonymousPatron AutoEmailPrimaryAddress AutoSelfCheckID AutoSelfCheckPass BakerTaylorPassword BranchTransferLimitsType defaultSortOrder FrameworksLoaded holdCancelLength ILS-DI:AuthorizedIPs kohaspsuggest libraryAddress marc MIME OAI-PMH:Set OAI-PMH:Subset OpacCloud OPACdefaultSortOrder OPACDisplayExtendedSubInfo OPACNoResultsFound OPACRerunSearch OPACSubscriptionDisplay OrderPdfTemplate pdfformat PINESISBN printcirculationslips RandomizeHoldsQueueWeight sortbynonfiling SyndeticsCoverImageSize TemplateEncoding Version z3950AuthorAuthFields Created attachment 2414 [details]
local use 1
Created attachment 2415 [details]
local use 2
Created attachment 2416 [details]
local use 3
note that this is after you click on local use - not the default local use tab you see when you visit sys prefs (In reply to comment #10) > note that this is after you click on local use - not the default local use tab > you see when you visit sys prefs Ok, this appears to be a result of Frédéric's patch. (http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=4dc85d2f0a7b8fb682fb0f492cc06c8f1a16bc31) According to the commit message for this patch: "As a side effect, local sysprefs editor displays also deprecated sysprefs which is a feature from my point of view. For example, GranularPermissions is displayed as a local syspref because it has been removed recently from admin.pref but hasn't been yet removed from DB (could be done later with a DB update)." However, this does not hold true in all cases. For example, AutoSelfCheckID and AutoSelfCheckPass show in the Local Pref tab now. Neither of these are deprecated sysprefs. (In reply to comment #11) > (In reply to comment #10) > > note that this is after you click on local use - not the default local use tab > > you see when you visit sys prefs > > Ok, this appears to be a result of Frédéric's patch. > (http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=4dc85d2f0a7b8fb682fb0f492cc06c8f1a16bc31) > According to the commit message for this patch: > > "As a side effect, local sysprefs editor displays also deprecated > sysprefs which is a feature from my point of view. For example, > GranularPermissions is displayed as a local syspref because it has been > removed recently from admin.pref but hasn't been yet removed from DB > (could be done later with a DB update)." > > However, this does not hold true in all cases. For example, AutoSelfCheckID and > AutoSelfCheckPass show in the Local Pref tab now. Neither of these are > deprecated sysprefs. Frédéric, Could you comment on this? This may be a 'feature' in the eyes of a developer, but it is very much not a feature for librarians trying to navigate through the hundreds of preferences already there. Also is a preference is deprecated doesn't that mean that the code is no longer in place for those preferences to work anyway?? > This may be a 'feature' in the eyes of a developer, but it is very much not a
> feature for librarians trying to navigate through the hundreds of preferences
> already there. Also is a preference is deprecated doesn't that mean that the
> code is no longer in place for those preferences to work anyway??
If your average Joe/Jane librarian noses around in the administration interface, you have first to fix your users permissions. Deprecated sysprefs should be removed at all before releasing 3.2 in the wild. In the meantime, it's better not to hide deprecated sysprefs in order not to forget to remove them.
> However, this does not hold true in all cases. For example, AutoSelfCheckID and
> AutoSelfCheckPass show in the Local Pref tab now. Neither of these are
> deprecated sysprefs.
I will fix that. Thanks.
(In reply to comment #14) > If your average Joe/Jane librarian noses around in the administration > interface, you have first to fix your users permissions. Deprecated sysprefs > should be removed at all before releasing 3.2 in the wild. In the meantime, > it's better not to hide deprecated sysprefs in order not to forget to remove > them. Isn't the point of this system that librarians can manage it themselves? I don't think that something should be left in as a reminder to developers - instead it should be in the comments in the code - where the developers are - not where the librarians are. I promote the power of Koha as anyone having the ability to edit the sys prefs themselves instead of needing an expert. Also this is the old sys prefs interface and doesn't flow with the look and feel of the rest of it. > Isn't the point of this system that librarians can manage it themselves? I > don't think that something should be left in as a reminder to developers - > instead it should be in the comments in the code - where the developers are - > not where the librarians are. I promote the power of Koha as anyone having the > ability to edit the sys prefs themselves instead of needing an expert. Also > this is the old sys prefs interface and doesn't flow with the look and feel of > the rest of it. As said Peter Parker alias Spider Man: With great power comes great responsibility. Your educated power librarians have not to be scared by their power. There are three categories of sysprefs in local tab: (1) true local syspref, (2) deprecated sysprefs and (3) false local syspref. I've send a patch to remove from local syspref tab, some sysprefs which belongs to other tabs: there were a bug. It solves (3). For (2) someone has to send a DB update to delete all deprecated syspref. You can be this person. This should be done before 3.2 as I already said. DELETE FROM systempreferences WHERE variable IN ('etc. Concerning the old syspref interface which has been resurrected for local syspref, I agree that it isn't coherent with the syspref editor but we already discussed this point on koha-devel. Something has to be done in 3.4. This has been discussed here: http://lists.koha-community.org/pipermail/koha-devel/2010-July/thread.html#34211 (In reply to comment #17) > For (2) someone has to send a DB update to delete all deprecated syspref. You > can be this person. This should be done before 3.2 as I already said. > > DELETE FROM systempreferences WHERE variable IN ('etc. > I misread what you said before - I'll gladly submit such a patch (that deletes these problem preferences). That will solve my problem ;) I know these three are definitely needed/in use: AutoEmailPrimaryAddress AutoSelfCheckID AutoSelfCheckPass Will have to check further on the others. > I know these three are definitely needed/in use:
>
> AutoEmailPrimaryAddress
> AutoSelfCheckID
> AutoSelfCheckID
AutoSelfCheckID and AutoSelfCheckID won't be displayed as local anymore as soon as my last patch will be applied since they exist in circulation template.
Same for AutoEmailPrimaryAddress which belongs to patron.tmpl.
Core issue is now resolved, and disused system preferences have been removed. Please file a separate bug for the remaining system preferences that appear in local use. *** Bug 4185 has been marked as a duplicate of this bug. *** |