Bug 37593

Summary: Fix typo in schema description for items.bookable
Product: Koha Reporter: Aude Charillon <aude.charillon>
Component: DatabaseAssignee: Jake Deery <jake.deery>
Status: RESOLVED FIXED QA Contact: Katrin Fischer <katrin.fischer>
Severity: minor    
Priority: P5 - low CC: fridolin.somers, jake.deery, jesse, lucas, martin.renvoize, wainuiwitikapark
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: String patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00
Circulation function:
Attachments: Bug 37593: Removed all instances of 'this this' in the codebase

Description Aude Charillon 2024-08-07 14:06:52 UTC
At both https://schema.koha-community.org/23_11/tables/items.html and https://schema.koha-community.org/24_05/tables/items.html the comment for the bookable column has the word "this" twice, when it shouldn't: "boolean value defining whether this this item is available for bookings or not".
Comment 1 Jake Deery 2024-08-12 14:29:08 UTC
Created attachment 170231 [details] [review]
Bug 37593: Removed all instances of 'this this' in the codebase

To test:
a)  do a grep for 'this this'
    1)  notice that there are five matching files
    2)  notice that all of these instances are in comments, or podfiles
b)  apply this patch
c)  do a grep for 'this this'
    1)  notice now that these instances are gone
d)  apply these changes to schema.koha-community.org
e)  result!
Comment 2 Jake Deery 2024-08-12 14:34:41 UTC
Note that I have also touched koha-tmpl/intranet-tmpl/lib/datatables/datatables.js -- only a one-line change, but snipper2 lists one signed off bug.

Just an FYI for the SO / QA!
Comment 3 Katrin Fischer 2024-08-12 14:37:27 UTC
I like typo fixes, speeding this up RM style.
Comment 4 Katrin Fischer 2024-08-16 14:25:20 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 5 Lucas Gass (lukeg) 2024-09-11 16:29:07 UTC
Backported to 24.05.x for 24.05.04
Comment 6 Fridolin Somers 2024-10-21 11:50:22 UTC
Pushed to 23.11.x for 23.11.10
Comment 7 Wainui Witika-Park 2024-11-03 23:56:40 UTC
Not backporting to 23.05.x unless requested
Comment 8 Jesse Maseto 2024-12-04 21:52:19 UTC
Not back porting to 22.11.x - Merge conflicts
Comment 9 Lucas Gass (lukeg) 2024-12-05 16:26:16 UTC
This needs to be reverted from 24.05.x, and likely 23.11. POD changed without updating checksum leads to checksum mismatch and errors when running dbic.
Comment 10 Lucas Gass (lukeg) 2024-12-05 16:27:10 UTC
Reverted from 24.05.x
Comment 11 Fridolin Somers 2024-12-06 13:14:33 UTC
Reverted from 23.11.x