| Summary: | t/db_dependent/Letters.t tests fails to consider EmailFieldPrimary system preference | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Aleisha Amohia <aleisha> |
| Component: | Test Suite | Assignee: | Aleisha Amohia <aleisha> |
| Status: | Pushed to oldstable --- | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | fridolin.somers, lucas, m.de.rooy, wainuiwitikapark |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | Sponsored | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
24.11.00,24.05.04,23.11.10
|
|
| Circulation function: | |||
| Bug Depends on: | 33192 | ||
| Bug Blocks: | 37598 | ||
| Attachments: |
Bug 37623: Make t/db_dependent/Letters.t idempotent
Bug 37623: Make t/db_dependent/Letters.t idempotent Bug 37623: Make t/db_dependent/Letters.t idempotent |
||
|
Description
Aleisha Amohia
2024-08-13 03:04:41 UTC
Created attachment 170251 [details] [review] Bug 37623: Make t/db_dependent/Letters.t idempotent The tests should be unaffected by system preference settings, such as EmailFieldPrimary. To test: 1. Log into the staff interface 2. Go to Koha Administration -> Global system preferences, and search for EmailFieldPrimary 3. Change the EmailFieldPrimary preference to something other than 'primary email' and 'first valid email address', i.e. any of the following: * alternate email * card number * secondary email * selected addresses 4. Run tests t/db_dependent/Letters.t and notice they fail 5. Apply the patch 6. Run the tests again t/db_dependent/Letters.t with different settings of EmailFieldPrimary. The tests should always pass. Sponsored-by: Pymble Ladies' College Created attachment 170410 [details] [review] Bug 37623: Make t/db_dependent/Letters.t idempotent The tests should be unaffected by system preference settings, such as EmailFieldPrimary. To test: 1. Log into the staff interface 2. Go to Koha Administration -> Global system preferences, and search for EmailFieldPrimary 3. Change the EmailFieldPrimary preference to something other than 'primary email' and 'first valid email address', i.e. any of the following: * alternate email * card number * secondary email * selected addresses 4. Run tests t/db_dependent/Letters.t and notice they fail 5. Apply the patch 6. Run the tests again t/db_dependent/Letters.t with different settings of EmailFieldPrimary. The tests should always pass. Sponsored-by: Pymble Ladies' College Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Created attachment 170423 [details] [review] Bug 37623: Make t/db_dependent/Letters.t idempotent The tests should be unaffected by system preference settings, such as EmailFieldPrimary. To test: 1. Log into the staff interface 2. Go to Koha Administration -> Global system preferences, and search for EmailFieldPrimary 3. Change the EmailFieldPrimary preference to something other than 'primary email' and 'first valid email address', i.e. any of the following: * alternate email * card number * secondary email * selected addresses 4. Run tests t/db_dependent/Letters.t and notice they fail 5. Apply the patch 6. Run the tests again t/db_dependent/Letters.t with different settings of EmailFieldPrimary. The tests should always pass. Sponsored-by: Pymble Ladies' College Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed for 24.11! Well done everyone, thank you! Backported to 24.05.x for upcoming 24.05.04 Pushed to 23.11.x for 23.11.10 Not backporting to 23.05.x unless requested |